Bug 34495 - ENABLE_DATABASE and ENABLE_DOM_STORAGE don't work in IDL files.
Summary: ENABLE_DATABASE and ENABLE_DOM_STORAGE don't work in IDL files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-02 12:22 PST by Lyon Chen
Modified: 2014-12-17 17:07 PST (History)
6 users (show)

See Also:

Attachments
Fix for bug 34495. (3.78 KB, patch)
2010-02-02 13:17 PST, Lyon Chen 		levin: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lyon Chen 2010-02-02 12:22:22 PST 
In following files, "#if defined(ENABLE_DATABASE) && ENABLE_DATABASE" and/or "#if defined(ENABLE_DOM_STORAGE) && ENABLE_DOM_STORAGE" are used and they don't work if ENABLE_DATABASE is defined as 0. But change them to #if ENABLE(DATABASE) or #if ENABLE(DOM_STORAGE) will work.

WebCore/inspector/InjectedScriptHost.idl
WebCore/inspector/InspectorBackend.idl
WebCore/page/DOMWindow.idl
WebCore/page/Navigator.idl

This seems a bug in the tool CodeGeneratorJS.pm, but seems ENABLE(XXX) is more widely used, so maybe anyway we should change to use this format (ENABLE(XXX).
Comment 1 Lyon Chen 2010-02-02 13:17:25 PST 
Created attachment 47970 [details]
Fix for bug 34495.

Use ENABLE(DATABASE) and ENABLE(DOM_STORAGE) in .idl files.
Comment 2 WebKit Review Bot 2010-02-02 13:37:08 PST 
Attachment 47970 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/229826
Comment 3 WebKit Review Bot 2010-02-02 13:52:09 PST 
Attachment 47970 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/229838
Comment 4 David Levin 2010-02-02 14:06:02 PST 
Comment on attachment 47970 [details]
Fix for bug 34495.

r- because it looks like this breaks the build for both qt and gtk.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +2010-02-02  Lyon Chen  <liachen@rim.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        ENABLE_DATABASE and ENABLE_DOM_STORAGE don't work in IDL files.
> +        https://bugs.webkit.org/show_bug.cgi?id=34495
> +
> +        No new tests. (OOPS!)

This should either list what tests cover this functionality or explain that there is no new functionality so no new tests. (I think you want the second in this case.)
\
Comment 5 Lyon Chen 2010-02-02 14:11:57 PST 
Thanks, David, I will check the code generator instead.
Comment 6 Brian Burg 2014-12-17 17:07:04 PST 
Can use Conditional attribute now.