Bug 34491 - [Skia] GraphicsContext::beginTransparencyLayer doesn't retain the compositing mode
Summary: [Skia] GraphicsContext::beginTransparencyLayer doesn't retain the compositing...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Garret Kelly
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-02 10:40 PST by Garret Kelly
Modified: 2013-04-09 12:51 PDT (History)
5 users (show)

See Also:

Attachments
Initial patch (3.83 KB, patch)
2010-02-02 10:42 PST, Garret Kelly 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Garret Kelly 2010-02-02 10:40:56 PST 
When using the Skia graphics context, the beginTransparencyLayer call currently creates a new layer, but does not keep the current compositing mode for use when merging the created layer back onto the rest of the context.

There's a test that exercises this functionality (fast/backgrounds/svg-ask-mask.html), but it's never passed in Chromium.
Comment 1 Garret Kelly 2010-02-02 10:42:02 PST 
Created attachment 47950 [details]
Initial patch
Comment 2 Eric Seidel (no email) 2010-02-02 14:24:02 PST 
It's still strange that we have a "PlatformContextSkia" abstraction layer. :)  But glad this is fixed.
Comment 3 WebKit Commit Bot 2010-02-02 15:06:59 PST 
Comment on attachment 47950 [details]
Initial patch

Clearing flags on attachment: 47950

Committed r54257: <http://trac.webkit.org/changeset/54257>
Comment 4 WebKit Commit Bot 2010-02-02 15:07:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Dimitri Glazkov (Google) 2010-02-02 16:06:38 PST 
Rolled out in http://trac.webkit.org/changeset/54262, because it broke basically all Win tests :)