Bug 34469 – Web Inspector: Separate OS type from OS version (WebInspector.platform)

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexander Pavlov (apavlov)]

Currently the WebInspector.platform value holds both the OS type (mac, windows, etc.) and the OS version (vista-or-later, leopard, etc.)
This complicates the stylesheet rules and results in a lot of duplication. This should be split up into two properties, say, WebInspector.osType and WebInspector.osVersion.

[Alexander Pavlov (apavlov)]

Created attachment 47931 [details]
[PATCH] Suggested solution

[Pavel Feldman]

Comment on attachment 47931 [details]
[PATCH] Suggested solution


> +body.detached.platform-snowleopard #toolbar {

I'd suggest to rename "platform-snowleopard" to "platform-mac-snowleopard" or "mac-snowleopard"

> +                return WebInspector.PlatformFlavor.WindowsVistaOrLater;

We don't seem to be consistent. We have vista or later, but don't have snow leopard or later. Should Vista imply newer platforms?

[Alexander Pavlov (apavlov)]

Created attachment 47936 [details]
[PATCH] Comments addressed

[Pavel Feldman]

Comment on attachment 47936 [details]
[PATCH] Comments addressed

> +        this._isMac = (WebInspector.platform === "mac");

No need for () here.

[Alexander Pavlov (apavlov)]

"(...)" fixed.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/inspector/front-end/InspectorBackendStub.js
        M       WebCore/inspector/front-end/InspectorFrontendHostStub.js
        M       WebCore/inspector/front-end/inspector.css
        M       WebCore/inspector/front-end/inspector.js
Committed r54240