Bug 34466 - [Chromium] WebSecurityOrigin::createFromDatabaseIdentifier should not return a pointer
Summary: [Chromium] WebSecurityOrigin::createFromDatabaseIdentifier should not return ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dumitru Daniliuc
Depends on:
Reported: 2010-02-01 23:46 PST by Jeremy Orlow
Modified: 2010-04-16 19:22 PDT (History)
1 user (show)

See Also:

patch (3.27 KB, patch)
2010-04-16 15:46 PDT, Dumitru Daniliuc
jorlow: review+
dumi: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-02-01 23:46:02 PST
WebSecurityOrigin::createFromDatabaseIdentifier should not return a pointer to a WebSecurityOrigin.  It should simply be a WebSecurityOrigin.
Comment 1 Jeremy Orlow 2010-02-11 12:11:53 PST
Thanks for taking that on Dumi!

If you're super brave, there are probably other places like this that can be changed.  If you're super duper brave, there are other places that can be changed like this IFF you add an equals operator to them (like WebStorageNamespace).  If you don't want to do that stuff, it's fine though.
Comment 2 Dumitru Daniliuc 2010-04-16 15:46:26 PDT
Created attachment 53573 [details]

Will land in Chromium as a 2-sided patch.
Comment 3 Jeremy Orlow 2010-04-16 15:58:42 PDT
Comment on attachment 53573 [details]

Please follow the standard changeLog conventions.
Comment 4 Dumitru Daniliuc 2010-04-16 19:22:38 PDT
Landed as r57768 in WebKit and 44870 in Chromium.