Bug 34460 - [Chromium] Add WebSecurityOrigin::createFromString factory
Summary: [Chromium] Add WebSecurityOrigin::createFromString factory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-01 18:17 PST by Jeremy Orlow
Modified: 2010-02-02 00:52 PST (History)
0 users

See Also:

Attachments
Patch (1.79 KB, patch)
2010-02-01 18:17 PST, Jeremy Orlow 		no flags Details | Formatted Diff | Diff
Patch (1.90 KB, patch)
2010-02-01 23:43 PST, Jeremy Orlow 		fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-02-01 18:17:09 PST 
[Chromium] Add WebSecurityOrigin::createFromString factory
Comment 1 Jeremy Orlow 2010-02-01 18:17:49 PST 
Created attachment 47894 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2010-02-01 22:55:06 PST 
Comment on attachment 47894 [details]
Patch

> Index: WebKit/chromium/public/WebSecurityOrigin.h

>      WEBKIT_API static WebSecurityOrigin* createFromDatabaseIdentifier(const WebString& databaseIdentifier);
> +    WEBKIT_API static WebSecurityOrigin* createFromString(const WebString& origin);

There's no reason for either of these to return pointers.

WebSecurityOrigin is already like a smart pointer class.  Just return by value.
Comment 3 Jeremy Orlow 2010-02-01 23:43:30 PST 
Created attachment 47908 [details]
Patch
Comment 4 Darin Fisher (:fishd, Google) 2010-02-02 00:09:19 PST 
Comment on attachment 47908 [details]
Patch

> Index: WebKit/chromium/public/WebSecurityOrigin.h
> +    WEBKIT_API static WebSecurityOrigin createFromString(const WebString& origin);

nit: nix the origin parameter name.

otherwise, r=me
Comment 5 Jeremy Orlow 2010-02-02 00:52:38 PST 
Committed r54214: <http://trac.webkit.org/changeset/54214>