RESOLVED FIXED 34460
[Chromium] Add WebSecurityOrigin::createFromString factory 
https://bugs.webkit.org/show_bug.cgi?id=34460
Summary [Chromium] Add WebSecurityOrigin::createFromString factory
Jeremy Orlow
Reported 2010-02-01 18:17:09 PST
[Chromium] Add WebSecurityOrigin::createFromString factory
Attachments
Patch (1.79 KB, patch)
2010-02-01 18:17 PST, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2010-02-01 23:43 PST, Jeremy Orlow 		fishd: review+
fishd: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-02-01 18:17:49 PST
Created attachment 47894 [details] Patch
Darin Fisher (:fishd, Google)
Comment 2 2010-02-01 22:55:06 PST
Comment on attachment 47894 [details] Patch > Index: WebKit/chromium/public/WebSecurityOrigin.h > WEBKIT_API static WebSecurityOrigin* createFromDatabaseIdentifier(const WebString& databaseIdentifier); > + WEBKIT_API static WebSecurityOrigin* createFromString(const WebString& origin); There's no reason for either of these to return pointers. WebSecurityOrigin is already like a smart pointer class. Just return by value.
Jeremy Orlow
Comment 3 2010-02-01 23:43:30 PST
Created attachment 47908 [details] Patch
Darin Fisher (:fishd, Google)
Comment 4 2010-02-02 00:09:19 PST
Comment on attachment 47908 [details] Patch > Index: WebKit/chromium/public/WebSecurityOrigin.h > + WEBKIT_API static WebSecurityOrigin createFromString(const WebString& origin); nit: nix the origin parameter name. otherwise, r=me
Jeremy Orlow
Comment 5 2010-02-02 00:52:38 PST
Committed r54214: <http://trac.webkit.org/changeset/54214>
Note You need to log in before you can comment on or make changes to this bug.