Bug 34453 - [V8] Raising an exception while setting timeout/interval from a detached frame
Summary: [V8] Raising an exception while setting timeout/interval from a detached frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Kavita Kanetkar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-01 15:54 PST by Kavita Kanetkar
Modified: 2010-02-02 04:43 PST (History)
3 users (show)

See Also:


Attachments
proposed fix (1.91 KB, patch)
2010-02-01 16:39 PST, Kavita Kanetkar
no flags Details | Formatted Diff | Diff
patch2 (2.05 KB, patch)
2010-02-01 18:39 PST, Kavita Kanetkar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kavita Kanetkar 2010-02-01 15:54:40 PST
In http://trac.webkit.org/changeset/53439, raising exception was added to JSC bindings. 
Doing the same in V8 bindings.
Comment 1 Kavita Kanetkar 2010-02-01 16:39:20 PST
Created attachment 47877 [details]
proposed fix
Comment 2 Dmitry Titov 2010-02-01 18:13:21 PST
Is it possible to test this?
Comment 3 Kavita Kanetkar 2010-02-01 18:16:55 PST
I tested it locally on my machine, but I do not have the permission to run it on tribots. Let me know.
Comment 4 Kavita Kanetkar 2010-02-01 18:39:49 PST
Created attachment 47898 [details]
patch2

Mentioned Chrome bug that has the layout test reference in ChangeLog.
Comment 5 Dmitry Titov 2010-02-01 18:43:54 PST
Comment on attachment 47898 [details]
patch2

So it fixes existing layout test that fails in Chromium (fast/dom/Window/timer-null-script-execution-context.html). Great.
r=me
Comment 6 WebKit Commit Bot 2010-02-02 04:43:46 PST
Comment on attachment 47898 [details]
patch2

Clearing flags on attachment: 47898

Committed r54227: <http://trac.webkit.org/changeset/54227>
Comment 7 WebKit Commit Bot 2010-02-02 04:43:53 PST
All reviewed patches have been landed.  Closing bug.