Bug 34450 – [Qt] Enable a way to measure FPS in QGVLauncher

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Noam Rosenthal]

This is needed in order to measure improvements to CSS accelerated compositing and general improvements to QtWebkit graphics

[Noam Rosenthal]

Created attachment 47871 [details]
Add a command line argument to enable crude FPS measurements in QGVLauncher

This is required for measuring improvements in QtWebkit graphics and in CSS accelerated-compositing.

[Ariya Hidayat]

Comment on attachment 47871 [details]
Add a command line argument to enable crude FPS measurements in QGVLauncher

> +        , m_measureFps(QApplication::instance()->arguments().contains("--fps"))

Maybe --show-fps is a better name?

> +        QTime now = QTime::currentTime();
> +        int msecs = m_startTime.msecsTo(now);
> +        int totalMsecs = m_totalStartTime.msecsTo(now);
> +        int totalFps = m_numTotalPaints * 1000 / totalMsecs;
> +        int curFps = m_numPaintsSinceLastMeasure * 1000 / msecs;

Please guard against divide-by-zero (yes, that might happen accidently :)

r- for this minor issues. Otherwise, looks good.

[Noam Rosenthal]

Created attachment 47881 [details]
FPS counter: changed name to --show-fps, guard from div-by-0

ok - this should do it.

[Noam Rosenthal]

Created attachment 47882 [details]
FPS counter: changed name to --show-fps, guard from div-by-0

oops, re-uploading

[Ariya Hidayat]

LGTM! Good job :)

[WebKit Commit Bot]

Comment on attachment 47882 [details]
FPS counter: changed name to --show-fps, guard from div-by-0

Clearing flags on attachment: 47882

Committed r54222: <http://trac.webkit.org/changeset/54222>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.