Bug 34425 - [Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
Summary: [Qt] WebSockets : Buffer the data in WebKit instead of QtNetwork
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Keywords: Qt, QtTriaged
Depends on:
Reported: 2010-02-01 06:39 PST by Yael
Modified: 2012-10-25 17:19 PDT (History)
3 users (show)

See Also:

Patch v1 (4.13 KB, patch)
2010-02-02 12:05 PST, Yael
no flags Details | Formatted Diff | Diff
Revert previous patch (3.85 KB, patch)
2010-02-03 09:04 PST, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-02-01 06:39:28 PST
Sending data to a websocket connection should be controlled by the signals bytesWritten() and encryptedBytesWritten() instead of assuming that all the data was sent when send() is called.
Comment 1 Markus Goetz 2010-02-01 06:42:06 PST
I agree. And check for the result of bytesToWrite() and encryptedBytesToWrite()
to keep the sum of both under a certain limit.

See similar code in QHttpNetworkConnectionChannel::sendRequest().
Comment 2 Yael 2010-02-02 12:05:03 PST
Created attachment 47961 [details]
Patch v1

Address the comments 14 and 15 from https://bugs.webkit.org/show_bug.cgi?id=34180.
Comment 3 Yael 2010-02-03 05:44:26 PST
Committed r54279: <http://trac.webkit.org/changeset/54279>
Comment 4 Yael 2010-02-03 09:04:18 PST
Created attachment 48043 [details]
Revert previous patch

The previous fix for this bug was a misunderstanding, and added un-necessary buffering. 
This patch is to revert the previous one, until a solution is found.
Comment 5 Yael 2010-02-03 14:01:43 PST
Reverted in r54298: <http://trac.webkit.org/changeset/54298>
Comment 6 Tor Arne Vestbø 2010-03-05 09:39:43 PST
Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs


  - The 'QtWebKit' component should be used for bugs/features in the public QtWebKit API layer, not to signify that the bug is specific to the Qt port of WebKit

Comment 7 Yael 2012-10-25 17:19:04 PDT
WebSockets implementation changed quite a lot since.
I do not plan to make these changes.