RESOLVED FIXED 34416
[Qt] Build without SSL support is broken 
https://bugs.webkit.org/show_bug.cgi?id=34416
Summary [Qt] Build without SSL support is broken
Henry Haverinen
Reported 2010-02-01 04:45:03 PST
If Qt is configured without SSL support, then the build breaks in SocketStreamHandler.
Attachments
build fix (2.96 KB, patch)
2010-02-01 06:59 PST, Henry Haverinen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yael
Comment 1 2010-02-01 06:42:50 PST
Sorry, I forgot about that.
Simon Hausmann
Comment 2 2010-02-01 06:48:31 PST
Henry has a patch coming up :)
Kenneth Rohde Christiansen
Comment 3 2010-02-01 06:52:57 PST
Our product manager is programming now? :-) rocks!
Henry Haverinen
Comment 4 2010-02-01 06:59:24 PST
Created attachment 47839 [details] build fix
Kenneth Rohde Christiansen
Comment 5 2010-02-01 07:02:18 PST
Comment on attachment 47839 [details] build fix You need to put the patch up for review, I have done so now. > + } else > m_socket = new QTcpSocket(this); > + > + if (!m_socket) > + return; Why did you add this early return. The new is supposed to return something valid, unless we are out of memory.
Simon Hausmann
Comment 6 2010-02-01 07:04:02 PST
Committed r54134: <http://trac.webkit.org/changeset/54134>
Henry Haverinen
Comment 7 2010-02-01 07:07:42 PST
(In reply to comment #5) > (From update of attachment 47839 [details]) > You need to put the patch up for review, I have done so now. > > + } else > > m_socket = new QTcpSocket(this); > > + > > + if (!m_socket) > > + return; > Why did you add this early return. The new is supposed to return something > valid, unless we are out of memory. The return is not related to the new just above it, but to an #ifndef'd new above it. Without SSL support, there's no way to create a valid socket for this case.
Kenneth Rohde Christiansen
Comment 8 2010-02-01 07:09:16 PST
(In reply to comment #7) > The return is not related to the new just above it, but to an #ifndef'd new > above it. Without SSL support, there's no way to create a valid socket for this > case. OK, great! :-)
Note You need to log in before you can comment on or make changes to this bug.