Bug 34411 - debug-safari doesn't pass --debug option to gdb-safari on MacOSX
Summary: debug-safari doesn't pass --debug option to gdb-safari on MacOSX
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-01 00:20 PST by Shinichiro Hamaji
Modified: 2010-02-18 01:18 PST (History)
2 users (show)

See Also:


Attachments
Patch v1 (1.38 KB, patch)
2010-02-01 00:21 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff
Patch v2 (1.09 KB, patch)
2010-02-17 21:14 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-02-01 00:20:22 PST
Because determinePassedConfiguration modifies @ARGV.
Comment 1 Shinichiro Hamaji 2010-02-01 00:21:01 PST
Created attachment 47818 [details]
Patch v1
Comment 2 Eric Seidel (no email) 2010-02-01 15:59:02 PST
This seems like  a systemic problem with our perl code.
Comment 3 Eric Seidel (no email) 2010-02-17 15:43:17 PST
Comment on attachment 47818 [details]
Patch v1

Doesn't webkitdirs.pm already have a function to return args like this?  It must.  How does run-webkit-tests --debug know to call build-dumprendertree with --debug otherwise?
Comment 4 Shinichiro Hamaji 2010-02-17 21:14:31 PST
Created attachment 48967 [details]
Patch v2
Comment 5 Shinichiro Hamaji 2010-02-17 21:15:01 PST
True. Thanks for the nice suggestion!
Comment 6 Adam Barth 2010-02-18 00:10:21 PST
Comment on attachment 48967 [details]
Patch v2

LGTM.  I'm not an expert on our perl code, however.
Comment 7 Shinichiro Hamaji 2010-02-18 01:17:56 PST
Comment on attachment 48967 [details]
Patch v2

Clearing flags on attachment: 48967

Committed r54947: <http://trac.webkit.org/changeset/54947>
Comment 8 Shinichiro Hamaji 2010-02-18 01:18:04 PST
All reviewed patches have been landed.  Closing bug.