Bug 34400 - Web Inspector: Fix rest of the NativeTextViewer (line numbers, conditional breakpoints, selection).
Summary: Web Inspector: Fix rest of the NativeTextViewer (line numbers, conditional br...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-31 13:55 PST by Pavel Feldman
Modified: 2010-02-01 06:07 PST (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed change. (10.06 KB, patch)
2010-01-31 13:57 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-01-31 13:55:18 PST
Some more testing and we are ready to flip the preferences bit.
Comment 1 Pavel Feldman 2010-01-31 13:57:40 PST
Created attachment 47799 [details]
[PATCH] Proposed change.
Comment 2 Timothy Hatcher 2010-01-31 14:00:23 PST
Comment on attachment 47799 [details]
[PATCH] Proposed change.

> +            return nextElement.offsetTop - element.offsetTop;
> +        } else
> +            return element.parentElement.offsetHeight - element.offsetTop;

NO need for the "} else" after a return.
Comment 3 Pavel Feldman 2010-02-01 06:07:12 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/NativeTextViewer.js
	M	WebCore/inspector/front-end/Settings.js
	M	WebCore/inspector/front-end/SourceFrame.js
	M	WebCore/inspector/front-end/TextEditor.js
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/textEditor.css
Committed r54133