Bug 34390 - Limit the scope of packing alignment to avoid MSVC C4103 warning.
Summary: Limit the scope of packing alignment to avoid MSVC C4103 warning.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-31 02:27 PST by Kwang Yul Seo
Modified: 2010-01-31 18:38 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2010-01-31 02:32 PST, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-01-31 02:27:52 PST 
Limit the scope of packing alignment with pack(push) and pack(pop) to avoid C4103.

C4103: alignment changed after including header.
Comment 1 Kwang Yul Seo 2010-01-31 02:32:18 PST 
Created attachment 47788 [details]
Patch
Comment 2 Kwang Yul Seo 2010-01-31 05:38:13 PST 
CC'ing aroben@apple.com who added #pragma pack(16) in http://trac.webkit.org/changeset/35684
Comment 3 WebKit Commit Bot 2010-01-31 18:37:56 PST 
Comment on attachment 47788 [details]
Patch

Clearing flags on attachment: 47788

Committed r54122: <http://trac.webkit.org/changeset/54122>
Comment 4 WebKit Commit Bot 2010-01-31 18:38:00 PST 
All reviewed patches have been landed.  Closing bug.