Bug 34378 – [Qt] WinCE buildfix after r52729

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Template Framework

[Patrick R. Gansterer]

Rename WTF_PLATFORM_*_ENDIAN to WTF_CPU_*_ENDIAN

[Patrick R. Gansterer]

Created attachment 47774 [details]
The patch

[Ariya Hidayat]

Comment on attachment 47774 [details]
The patch

LGTM.

Maybe fix that typo (Q_BIG_EDIAN) as well?

[Patrick R. Gansterer]

Created attachment 47823 [details]
The patch (typo fixed)

[Zoltan Herczeg]

The patch looks good to me, although the comment says:

   We can not determine the endianess at compile time.

If this comment is not valid anymore, please remove or modify it. Furthermore, please do not set commit‑queue flags in the future. It should only be enabled after your patch is accepted.

[Patrick R. Gansterer]

(In reply to comment #4)
> The patch looks good to me, although the comment says:
> 
>    We can not determine the endianess at compile time.
> 
> If this comment is not valid anymore, please remove or modify it. Furthermore,
> please do not set commit‑queue flags in the future. It should only be enabled
> after your patch is accepted.
Currently i compile JSC without Qt. Platform.h "dedects" MIDDLE_ENDIAN which is wrong! So i think the comment is valid.

I want to change this to the following in a further patch:
#if OS(WINCE)
#   undef WTF_CPU_BIG_ENDIAN
#   undef WTF_CPU_MIDDLE_ENDIAN
#   if PLATFORM(QT)
#       include <QtGlobal>
#       if Q_BYTE_ORDER == Q_BIG_ENDIAN
#           define WTF_CPU_BIG_ENDIAN 1
#       endif
#   endif
#   include <ce_time.h>
#endif

[Zoltan Herczeg]

> I want to change this to the following in a further patch:

Fixing fixes is not really a WebKit style. Please do this change in patch.

[Patrick R. Gansterer]

(In reply to comment #6)
> > I want to change this to the following in a further patch:
> 
> Fixing fixes is not really a WebKit style. Please do this change in patch.

What should i do now?
Changing WTF_PLATFORM_*_ENDIAN to WTF_CPU_*_ENDIAN is _only_ a buildfix.
Should i change it to comment #5 or should i change the whole ARM ENDIAN DEDECTION (add ugly OS(WINCE))?

[WebKit Commit Bot]

Comment on attachment 47823 [details]
The patch (typo fixed)

Clearing flags on attachment: 47823

Committed r54176: <http://trac.webkit.org/changeset/54176>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.