Bug 34364 – REGRESSION(canvas editor): URLs are not syntax-higlighted as links in source view

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mark Rowe (bdash)]

In r54084 I've noticed that URLs are no longer syntax-highlighted as links in the source view of the Resources pane.  This works correctly in a build of WebKit from earlier in the week.

[Mark Rowe (bdash)]

<rdar://problem/7594380>

[Pavel Feldman]

Created attachment 47869 [details]
[PATCH] Proposed change.

[Timothy Hatcher]

Comment on attachment 47869 [details]
[PATCH] Proposed change.

> +        if (content.length > 1 && (quote === "\"" ||   quote === "'"))
> +            content = content.substring(1, content.length - 1);

Shouldn't this be content.length >= 2 or content.length > 2?

[Pavel Feldman]

(In reply to comment #3)
> (From update of attachment 47869 [details])
> > +        if (content.length > 1 && (quote === "\"" ||   quote === "'"))
> > +            content = content.substring(1, content.length - 1);
> 
> Shouldn't this be content.length >= 2 or content.length > 2?

Yeah, you are probably right - I first thought that empty string is a valid case, but it really makes no sense to linkify it. I'll fix.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/NativeTextViewer.js
	M	WebCore/inspector/front-end/SourceFrame.js
	M	WebCore/inspector/front-end/SourceHTMLTokenizer.js
	M	WebCore/inspector/front-end/SourceHTMLTokenizer.re2js
	M	WebCore/inspector/front-end/SourceView.js
	M	WebCore/inspector/front-end/TextEditorHighlighter.js
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/inspector.js
	M	WebCore/inspector/front-end/inspectorSyntaxHighlight.css
Committed r54231