Bug 34343 - Client-based Geolocation starts updating before getting consent from the user
Summary: Client-based Geolocation starts updating before getting consent from the user
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-29 13:22 PST by Steve Falkenburg
Modified: 2010-01-29 14:08 PST (History)
0 users

See Also:


Attachments
Patch (4.05 KB, patch)
2010-01-29 13:35 PST, Steve Falkenburg
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-01-29 13:22:21 PST
Client-based Geolocation starts updating before getting consent from the user
Comment 1 Steve Falkenburg 2010-01-29 13:35:10 PST
Created attachment 47732 [details]
Patch
Comment 2 Darin Adler 2010-01-29 13:45:23 PST
Comment on attachment 47732 [details]
Patch

> +            ASSERT(m_frame);
> +            Page* page = m_frame->page();
> +            ASSERT(page);
> +            page->geolocationController()->addObserver(this);

What guarantees they are non-zero? You should figure out what the right behavior would be in those cases and handle instead of asserting.

Otherwise, r=me
Comment 3 Steve Falkenburg 2010-01-29 14:08:29 PST
Committed r54079: <http://trac.webkit.org/changeset/54079>