Bug 34329 – Cannot inspect Web Inspector in QtLauncher

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Jessie Berlin]

The only option in the context menu that appears when right-clicking inside the Web Inspector is to Reload. It would very helpful to those who want to work on the Web Inspector while living on the Linux platform for it to be possible to inspect the Web Inspector (as can be done inside Safari on Mac OS X and Windows).

Briefly looking into the code for the QWebInspector, it appears that it sub-classes QWidget and is just using the default context menus for that. Is there a way to get at the QWebPage that contains the code for the Web Inspector (if there is one)?

[Jessie Berlin]

Created attachment 47903 [details]
Patch to enable inspecting the web inspector in the QtLauncher

[Holger Freyther]

Comment on attachment 47903 [details]
Patch to enable inspecting the web inspector in the QtLauncher

I love the patch. It sucks to have comments on a one liner. So if you fix them you can land the patch rightaway.


> +        Need a short description and bug URL (OOPS!)

Please remove this. You have done everything that is needed for this.

>      InspectorClientWebPage(QObject* parent = 0)
> -    : QWebPage(parent)
> +        : QWebPage(parent)

Even if you fix the style, we normally tend to do this in two separate commits. You have my rubber stamp to fix this style issue with the code.

[Jessie Berlin]

(In reply to comment #2)
> (From update of attachment 47903 [details])
> I love the patch. It sucks to have comments on a one liner. So if you fix them
> you can land the patch rightaway.
> 

So r=you on the first patch which just removes the line setting the DeveloperExtraEnabled setting and then rs=you on a second patch that fixes the style? Or do you want me to repost the first patch here?

> 
> > +        Need a short description and bug URL (OOPS!)
> 
> Please remove this. You have done everything that is needed for this.

Whoops! Sorry about that.

> 
> >      InspectorClientWebPage(QObject* parent = 0)
> > -    : QWebPage(parent)
> > +        : QWebPage(parent)
> 
> Even if you fix the style, we normally tend to do this in two separate commits.
> You have my rubber stamp to fix this style issue with the code.

[Jessie Berlin]

Enabled inspecting the web inspector in the qt launcher:

http://trac.webkit.org/changeset/54233

Will commit the style change next.

[Jessie Berlin]

(In reply to comment #4)
> Enabled inspecting the web inspector in the qt launcher:
> 
> http://trac.webkit.org/changeset/54233
> 
> Will commit the style change next.

Committed style change:

http://trac.webkit.org/changeset/54236

Closing bug.