Bug 34319 - Web Inspector: wire together buttons on welcome view and on status bar
Summary: Web Inspector: wire together buttons on welcome view and on status bar
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Mikhail Naganov
Depends on:
Reported: 2010-01-29 02:43 PST by Mikhail Naganov
Modified: 2010-03-29 02:06 PDT (History)
1 user (show)

See Also:

proposed patch (4.92 KB, patch)
2010-01-29 02:46 PST, Mikhail Naganov
pfeldman: review-
Details | Formatted Diff | Diff
another approach (4.63 KB, patch)
2010-03-26 09:07 PDT, Mikhail Naganov
pfeldman: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2010-01-29 02:43:08 PST
In Profiles panel, pressing buttons on the Welcome view doesn't change their look, only status bar button repaints itself. This is confusing, because it may appear to an user that the welcome view button doesn't work.

I think, welcome view and status bar buttons must update their look regardless of what button was pressed.
Comment 1 Mikhail Naganov 2010-01-29 02:46:38 PST
Created attachment 47692 [details]
proposed patch
Comment 2 Pavel Feldman 2010-01-29 02:56:42 PST
Comment on attachment 47692 [details]
proposed patch

It is now even more confusing - once you toggle a button, welcome message stops making sense: it suggests that red button starts the profiler.
Comment 3 Mikhail Naganov 2010-03-26 09:07:48 PDT
Created attachment 51745 [details]
another approach

OK, another approach, this time by limiting functionality.

This is how it looks like: http://i42.tinypic.com/dgt5wk.png
Comment 4 Pavel Feldman 2010-03-28 05:08:59 PDT
Comment on attachment 51745 [details]
another approach

Note that you could attach the screenshot to the bug.
Comment 5 Mikhail Naganov 2010-03-29 02:06:15 PDT
Manually committed r56711: http://trac.webkit.org/changeset/56711

Author: mnaganov@chromium.org <mnaganov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Mon Mar 29 08:52:19 2010 +0000

    2010-03-29  Mikhail Naganov  <mnaganov@chromium.org>
            Reviewed by Pavel Feldman.
            Remove a possibility of confusion from Profiles panel Welcome screen
            by turning buttons into non-clickable glyphs. Also, span instructions
            alongside panel width.
            * English.lproj/localizedStrings.js:
            * inspector/front-end/ProfileView.js:
            (WebInspector.CPUProfileType.prototype.get welcomeMessage):
            * inspector/front-end/ProfilesPanel.js:
            * inspector/front-end/inspector.css:
            (.panel-enabler-view.welcome .instructions):
            (.panel-enabler-view.welcome button.status-bar-item):
            * src/js/HeapProfilerPanel.js:
            (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):