Bug 34312 - [Win] Utilize PrintContext to share the printing code with other ports
Summary: [Win] Utilize PrintContext to share the printing code with other ports
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P2 Normal
Assignee: Shinichiro Hamaji
Depends on:
Reported: 2010-01-28 23:05 PST by Shinichiro Hamaji
Modified: 2010-02-02 03:07 PST (History)
6 users (show)

See Also:

Patch v1 (4.91 KB, patch)
2010-01-28 23:50 PST, Shinichiro Hamaji
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-01-28 23:05:55 PST
PrintContext::computePageRects is very similar to computePageRectsForFrame in WebCore/page/FrameWin.cpp. We should be able to share the code. This is another instance of Bug 18578. A patch will come soon later.
Comment 1 Shinichiro Hamaji 2010-01-28 23:50:07 PST
Created attachment 47683 [details]
Patch v1
Comment 2 Shinichiro Hamaji 2010-01-28 23:53:18 PST
I manually tested this patch by print-preview and didn't see any difference between before and after this patch. Please let me know if there are something I must check.
Comment 3 Eric Seidel (no email) 2010-02-01 15:51:58 PST
Comment on attachment 47683 [details]
Patch v1

Looks sane to me.
Comment 4 Eric Seidel (no email) 2010-02-01 16:13:34 PST
Attachment 47683 [details] was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit.
Comment 5 Shinichiro Hamaji 2010-02-02 03:07:33 PST
Committed r54221: <http://trac.webkit.org/changeset/54221>