Bug 34309 - MSAA: Crash when posting a notification for a detached object
Summary: MSAA: Crash when posting a notification for a detached object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-01-28 22:41 PST by Jon Honeycutt
Modified: 2010-01-29 13:56 PST (History)
0 users

See Also:


Attachments
patch (31.24 KB, patch)
2010-01-29 00:33 PST, Jon Honeycutt
darin: review+
jhoneycutt: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2010-01-28 22:41:48 PST
A crash occurs when a notification is posted for an object that has been detached from the document.

<rdar://problem/7409759>
Comment 1 Jon Honeycutt 2010-01-29 00:33:08 PST
Created attachment 47687 [details]
patch
Comment 2 Darin Adler 2010-01-29 09:31:24 PST
Comment on attachment 47687 [details]
patch

> +        * accessibility/AccessibilityRenderObject.cpp:
> +        (AccessibilityRenderObject::document):
> +        Null check m_renderer.

I presume this is the bug fix.

> +        * accessibility/win/AXObjectCacheWin.cpp:
> +        (WebCore::AXObjectCache::postPlatformNotification):
> +        Map AXValueChanged to EVENT_OBJECT_VALUECHANGED.

What does this have to do with the bug report? Is it just something else you noticed when making the test case?

I must admit this is one of the largest patches I have ever seen to fix a null-dereference!

r=me
Comment 3 Jon Honeycutt 2010-01-29 12:18:05 PST
(In reply to comment #2)
> (From update of attachment 47687 [details])
> > +        * accessibility/AccessibilityRenderObject.cpp:
> > +        (AccessibilityRenderObject::document):
> > +        Null check m_renderer.
> 
> I presume this is the bug fix.

Yes, this is the fix. I'll mention this in the changelog.

> 
> > +        * accessibility/win/AXObjectCacheWin.cpp:
> > +        (WebCore::AXObjectCache::postPlatformNotification):
> > +        Map AXValueChanged to EVENT_OBJECT_VALUECHANGED.
> 
> What does this have to do with the bug report? Is it just something else you
> noticed when making the test case?

This is required for us to receive the value change event that lets us know that the test passed without crashing. I'll mention that, too.

Thanks for the review!
Comment 4 Jon Honeycutt 2010-01-29 13:56:42 PST
Landed in r54078.