StorageNamespaceProxy::copy() should be a no-op
Created attachment 47664 [details] Patch
It's worth noting the current behavior asserts NOT REACHED when m_storageNamespace->copy() is called. :-)
Comment on attachment 47664 [details] Patch > + // The WebViewClient knows what its session storage namespace id is but we > + // do not. Returning 0 here causes it to be fetched (via theWebViewClient) nit: "theWebViewClient" -> "the WebViewClient" > + // on its next use. Note that it is WebViewClient::createView's > + // responsibility to clone the session storage namespace id and that the > + // only time copy() is called is directly after the createView call...which > + // is why all of this is safe. nit: It seems like some of this should be documented on WebViewClient::createView. R=me Feel free to fixup comments and commit.
Committed r54046: <http://trac.webkit.org/changeset/54046>