Bug 34273 - Web Inspector: migrate to tokenizer-based highlighting in the Elements panel.
Summary: Web Inspector: migrate to tokenizer-based highlighting in the Elements panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-28 10:00 PST by Pavel Feldman
Modified: 2010-01-29 03:04 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed change. (134.31 KB, patch)
2010-01-28 10:02 PST, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-01-28 10:00:43 PST 
Currently we use two types of highlighters: regex-based one for elements panel and lex-based one for the source view. Latter seems to be faster, we should migrate to it.
Comment 1 Pavel Feldman 2010-01-28 10:02:22 PST 
Created attachment 47626 [details]
[PATCH] Proposed change.
Comment 2 Pavel Feldman 2010-01-29 03:04:19 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	WebCore/inspector/front-end/CSSSourceSyntaxHighlighter.js
	D	WebCore/inspector/front-end/JavaScriptSourceSyntaxHighlighter.js
	D	WebCore/inspector/front-end/SourceSyntaxHighlighter.js
	M	LayoutTests/ChangeLog
	M	LayoutTests/inspector/syntax-highlight-css-expected.txt
	M	LayoutTests/inspector/syntax-highlight-css.html
	M	LayoutTests/inspector/syntax-highlight-javascript-expected.txt
	M	LayoutTests/inspector/syntax-highlight-javascript.html
	M	LayoutTests/inspector/syntax-highlight.js
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	A	WebCore/inspector/front-end/DOMSyntaxHighlighter.js
	M	WebCore/inspector/front-end/ElementsTreeOutline.js
	M	WebCore/inspector/front-end/SourceCSSTokenizer.js
	M	WebCore/inspector/front-end/SourceCSSTokenizer.re2js
	M	WebCore/inspector/front-end/SourceHTMLTokenizer.js
	M	WebCore/inspector/front-end/SourceHTMLTokenizer.re2js
	M	WebCore/inspector/front-end/SourceJavaScriptTokenizer.js
	M	WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js
	A	WebCore/inspector/front-end/SourceTokenizer.js
	M	WebCore/inspector/front-end/TextEditorHighlighter.js
	M	WebCore/inspector/front-end/WebKit.qrc
	M	WebCore/inspector/front-end/inspector.html
Committed r54053