RESOLVED FIXED 34273
Web Inspector: migrate to tokenizer-based highlighting in the Elements panel. 
https://bugs.webkit.org/show_bug.cgi?id=34273
Summary Web Inspector: migrate to tokenizer-based highlighting in the Elements panel.
Pavel Feldman
Reported 2010-01-28 10:00:43 PST
Currently we use two types of highlighters: regex-based one for elements panel and lex-based one for the source view. Latter seems to be faster, we should migrate to it.
Attachments
[PATCH] Proposed change. (134.31 KB, patch)
2010-01-28 10:02 PST, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-01-28 10:02:22 PST
Created attachment 47626 [details] [PATCH] Proposed change.
Pavel Feldman
Comment 2 2010-01-29 03:04:19 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... D WebCore/inspector/front-end/CSSSourceSyntaxHighlighter.js D WebCore/inspector/front-end/JavaScriptSourceSyntaxHighlighter.js D WebCore/inspector/front-end/SourceSyntaxHighlighter.js M LayoutTests/ChangeLog M LayoutTests/inspector/syntax-highlight-css-expected.txt M LayoutTests/inspector/syntax-highlight-css.html M LayoutTests/inspector/syntax-highlight-javascript-expected.txt M LayoutTests/inspector/syntax-highlight-javascript.html M LayoutTests/inspector/syntax-highlight.js M WebCore/ChangeLog M WebCore/WebCore.gypi M WebCore/WebCore.vcproj/WebCore.vcproj A WebCore/inspector/front-end/DOMSyntaxHighlighter.js M WebCore/inspector/front-end/ElementsTreeOutline.js M WebCore/inspector/front-end/SourceCSSTokenizer.js M WebCore/inspector/front-end/SourceCSSTokenizer.re2js M WebCore/inspector/front-end/SourceHTMLTokenizer.js M WebCore/inspector/front-end/SourceHTMLTokenizer.re2js M WebCore/inspector/front-end/SourceJavaScriptTokenizer.js M WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js A WebCore/inspector/front-end/SourceTokenizer.js M WebCore/inspector/front-end/TextEditorHighlighter.js M WebCore/inspector/front-end/WebKit.qrc M WebCore/inspector/front-end/inspector.html Committed r54053
Note You need to log in before you can comment on or make changes to this bug.