Bug 34272 - [Android] V8 Bindings are missing numerous forward-declarations and includes
Summary: [Android] V8 Bindings are missing numerous forward-declarations and includes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-28 09:50 PST by Steve Block
Modified: 2010-01-29 04:35 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2010-01-28 10:42 PST, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-01-28 09:50:17 PST
In the V8 Bindings, numerous numerous forward-declarations and includes are picked up through includes guarded by feature or platform flags. This causes build errors on Android, where these flags may not be enabled.

- Scriptcontroller.h - Need to forward declare NPObject
  Chromium picks this up though V8Proxy.h -> ChromiumBridge.h
- V8DOMWrapper.h - Need to forward declare V8Proxy
  Chromium picks this up through V8CustomXpathNSResolver.h, the contents of which are guarded with XPATH
- V8DOMWindowShell.cpp - Need to include CString.h and PlatformBridge.h for Android
Comment 1 Steve Block 2010-01-28 10:42:11 PST
Created attachment 47630 [details]
Patch
Comment 2 Adam Barth 2010-01-28 10:45:18 PST
Comment on attachment 47630 [details]
Patch

Those are mostly my mistakes.  Thanks for fixing them.

How close are we to having Android buildable from svn.webkit.org?  That's the best way to catch future regressions like these.
Comment 3 WebKit Commit Bot 2010-01-28 13:34:53 PST
Comment on attachment 47630 [details]
Patch

Clearing flags on attachment: 47630

Committed r54014: <http://trac.webkit.org/changeset/54014>
Comment 4 WebKit Commit Bot 2010-01-28 13:34:58 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Steve Block 2010-01-29 04:35:43 PST
> How close are we to having Android buildable from svn.webkit.org?  That's the
> best way to catch future regressions like these.
We've so far made good progress with upstreaming the Android changes back to webkit.org. We're going as fast as we can and hope to be done by the end of Spring. Thanks for all your help with reviewing!