RESOLVED FIXED Bug 34259
[BREWMP] Port userIdleTime
https://bugs.webkit.org/show_bug.cgi?id=34259
Summary [BREWMP] Port userIdleTime
Kwang Yul Seo
Reported 2010-01-28 06:15:18 PST
Return an arbitrarily high userIdleTime so that releasing pages from the page cache isn't postponed.
Attachments
Port userIdleTime (2.53 KB, patch)
2010-01-28 06:17 PST, Kwang Yul Seo
eric: review-
Port userIdleTime (2.47 KB, patch)
2010-02-04 23:48 PST, Kwang Yul Seo
no flags
Kwang Yul Seo
Comment 1 2010-01-28 06:17:22 PST
Created attachment 47613 [details] Port userIdleTime
Eric Seidel (no email)
Comment 2 2010-02-01 15:46:49 PST
Comment on attachment 47613 [details] Port userIdleTime This seems like a bad way to do this. Isn't there another way besides this hack?
Eric Seidel (no email)
Comment 3 2010-02-01 15:47:21 PST
Also, the year is now 2010, and I don't see how Apple's copyright would be needed on this file, since it looks nothing like any Apple version of this file.
Kwang Yul Seo
Comment 4 2010-02-04 23:47:07 PST
(In reply to comment #2) > (From update of attachment 47613 [details]) > This seems like a bad way to do this. Isn't there another way besides this > hack? Because BREWMP is a mobile platform, I don't want to postpone releasing pages. I think returning FLT_MAX is not so bad. Besides many ports do the same thing.
Kwang Yul Seo
Comment 5 2010-02-04 23:48:00 PST
Created attachment 48205 [details] Port userIdleTime Remove Apple's copyright and modified the year to 2010.
Eric Seidel (no email)
Comment 6 2010-02-17 15:35:40 PST
Comment on attachment 48205 [details] Port userIdleTime Bleh. It sucks that so many ports use this hack.
WebKit Commit Bot
Comment 7 2010-02-17 17:19:16 PST
Comment on attachment 48205 [details] Port userIdleTime Clearing flags on attachment: 48205 Committed r54915: <http://trac.webkit.org/changeset/54915>
WebKit Commit Bot
Comment 8 2010-02-17 17:19:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.