Bug 34256 - Some js files in LayoutTests/fast/event/script-tests should move to LayoutTests/fast/event/touch/script-tests.
Summary: Some js files in LayoutTests/fast/event/script-tests should move to LayoutTes...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-28 05:55 PST by Hayato Ito
Modified: 2010-02-02 14:18 PST (History)
1 user (show)

See Also:


Attachments
move-js-files (17.83 KB, patch)
2010-01-28 06:01 PST, Hayato Ito
no flags Details | Formatted Diff | Diff
Move JS files (19.22 KB, patch)
2010-01-28 21:36 PST, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2010-01-28 05:55:42 PST
The following three files in LayoutTests/fast/event/script-tests directory should move to LayoutTests/fast/event/touch/script-tests directory.
  - basic-touch-event.js
  - create-touch-event.js
  - send-oncancel-event.js, 

Unless that, make-test-script-wrapper wrongly genereates html files in LayoutTests/fast/event directory instead of LayoutTests/fast/event/touch, where the corresponding {...}-expected.txt files exist.
Comment 1 Hayato Ito 2010-01-28 06:01:25 PST
Created attachment 47609 [details]
move-js-files
Comment 2 Hayato Ito 2010-01-28 06:02:38 PST
I've moved the js files and updated the html files.
Comment 3 Hayato Ito 2010-01-28 06:08:20 PST
Hmm.
I am using git and I used webkit-patch script to send a patch.
It seems webkit-patch didn't generate a patch that is aware of 'file renaming'.

I'll send a patch using pure svn later.
Comment 4 Hayato Ito 2010-01-28 21:36:59 PST
Created attachment 47674 [details]
Move JS files

I've used 'svn-create-patch' script this time to make the patch to preserve 'file renaming' infomation.
Comment 5 WebKit Commit Bot 2010-02-02 14:18:11 PST
Comment on attachment 47674 [details]
Move JS files

Clearing flags on attachment: 47674

Committed r54253: <http://trac.webkit.org/changeset/54253>
Comment 6 WebKit Commit Bot 2010-02-02 14:18:16 PST
All reviewed patches have been landed.  Closing bug.