Bug 34254 - [WML] Build error in WML enabled build.
: [WML] Build error in WML enabled build.
Status: RESOLVED FIXED
: WebKit
WebKit Gtk
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-01-28 05:26 PST by
Modified: 2010-01-28 17:15 PST (History)


Attachments
Patch to fix compilation error. (1006 bytes, patch)
2010-01-28 05:38 PST, Nayan
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-01-28 05:26:16 PST
With the changeset 53514, WML enabled builds are failing with following errors,

  CXX    WebCore/wml/libwebkit_1_0_la-WMLDocument.lo
  CXX    WebCore/wml/libwebkit_1_0_la-WMLElement.lo
WebCore/wml/WMLDocument.cpp: In constructor ‘WebCore::WMLDocument::WMLDocument(WebCore::Frame*)’:
WebCore/wml/WMLDocument.cpp:39: error: no matching function for call to ‘WebCore::Document::Document(WebCore::Frame*&, bool)’
./WebCore/dom/Document.h:938: note: candidates are: WebCore::Document::Document(WebCore::Frame*, bool, bool)
./WebCore/dom/Document.h:178: note:                 WebCore::Document::Document(const WebCore::Document&)
make[1]: *** [WebCore/wml/libwebkit_1_0_la-WMLDocument.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/nayan/webkit/WebKit-SVN'
make: *** [all] Error 2
------- Comment #1 From 2010-01-28 05:38:00 PST -------
Created an attachment (id=47608) [details]
Patch to fix compilation error.
------- Comment #2 From 2010-01-28 07:03:49 PST -------
(From update of attachment 47608 [details])
My mistake, un-intentionally set review flag to '+' instead of '?'!. Correcting it.
------- Comment #3 From 2010-01-28 12:25:49 PST -------
(From update of attachment 47608 [details])
r=me.
------- Comment #4 From 2010-01-28 17:15:14 PST -------
(From update of attachment 47608 [details])
Clearing flags on attachment: 47608

Committed r54030: <http://trac.webkit.org/changeset/54030>
------- Comment #5 From 2010-01-28 17:15:18 PST -------
All reviewed patches have been landed.  Closing bug.