RESOLVED FIXED 34252
make-script-test-wrapper can not handle js file which contains NULL char. 
https://bugs.webkit.org/show_bug.cgi?id=34252
Summary make-script-test-wrapper can not handle js file which contains NULL char.
Hayato Ito
Reported 2010-01-28 03:46:13 PST
WebKitTools/Script/make-script-test-wrapper handle js file wrongly if the js file contains NULL char. For example, if you run make-script-test-wrapper script, LayoutTests/fast/js/script-tests/null-char-in-string.js is wrongly modified, which should not be touched.
Attachments
remove-null-char-from-input-js-file (1.17 KB, patch)
2010-01-28 04:07 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2010-01-28 04:07:09 PST
Created attachment 47604 [details] remove-null-char-from-input-js-file
Hayato Ito
Comment 2 2010-01-28 04:09:12 PST
I've attached the patch, which removes NULL char form input JS file.
Darin Adler
Comment 3 2010-01-28 12:45:25 PST
Comment on attachment 47604 [details] remove-null-char-from-input-js-file Why do we need to handle input files with \0 characters in them??
Darin Adler
Comment 4 2010-01-28 12:45:50 PST
Comment on attachment 47604 [details] remove-null-char-from-input-js-file Oh, I see there is one test that has one. OK.
WebKit Commit Bot
Comment 5 2010-01-28 17:32:56 PST
Comment on attachment 47604 [details] remove-null-char-from-input-js-file Clearing flags on attachment: 47604 Committed r54033: <http://trac.webkit.org/changeset/54033>
WebKit Commit Bot
Comment 6 2010-01-28 17:33:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.