Bug 34252 - make-script-test-wrapper can not handle js file which contains NULL char.
Summary: make-script-test-wrapper can not handle js file which contains NULL char.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-28 03:46 PST by Hayato Ito
Modified: 2010-01-28 17:33 PST (History)
1 user (show)

See Also:


Attachments
remove-null-char-from-input-js-file (1.17 KB, patch)
2010-01-28 04:07 PST, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2010-01-28 03:46:13 PST
WebKitTools/Script/make-script-test-wrapper handle js file wrongly if the js file contains NULL char.

For example,  if you run make-script-test-wrapper script,  LayoutTests/fast/js/script-tests/null-char-in-string.js is wrongly modified, which should not be touched.
Comment 1 Hayato Ito 2010-01-28 04:07:09 PST
Created attachment 47604 [details]
remove-null-char-from-input-js-file
Comment 2 Hayato Ito 2010-01-28 04:09:12 PST
I've attached the patch, which removes NULL char form input JS file.
Comment 3 Darin Adler 2010-01-28 12:45:25 PST
Comment on attachment 47604 [details]
remove-null-char-from-input-js-file

Why do we need to handle input files with \0 characters in them??
Comment 4 Darin Adler 2010-01-28 12:45:50 PST
Comment on attachment 47604 [details]
remove-null-char-from-input-js-file

Oh, I see there is one test that has one. OK.
Comment 5 WebKit Commit Bot 2010-01-28 17:32:56 PST
Comment on attachment 47604 [details]
remove-null-char-from-input-js-file

Clearing flags on attachment: 47604

Committed r54033: <http://trac.webkit.org/changeset/54033>
Comment 6 WebKit Commit Bot 2010-01-28 17:33:01 PST
All reviewed patches have been landed.  Closing bug.