Bug 34245 - Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h}
Summary: Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-28 00:55 PST by Kent Tamura
Modified: 2010-01-28 08:47 PST (History)
2 users (show)

See Also:


Attachments
Patch (85.18 KB, patch)
2010-01-28 00:57 PST, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch (86.09 KB, patch)
2010-01-28 01:03 PST, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-01-28 00:55:48 PST
Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h}
Comment 1 Kent Tamura 2010-01-28 00:57:08 PST
Created attachment 47596 [details]
Patch
Comment 2 WebKit Review Bot 2010-01-28 00:58:23 PST
Attachment 47596 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Skipping input 'WebCore/html/ISODateTime.cpp': Can't open for reading
WebCore/html/DateComponents.h:160:  One space before end of line comments  [whitespace/comments] [5]
WebCore/html/DateComponents.h:164:  One space before end of line comments  [whitespace/comments] [5]
WebCore/html/DateComponents.h:165:  One space before end of line comments  [whitespace/comments] [5]
WebCore/html/DateComponents.h:166:  One space before end of line comments  [whitespace/comments] [5]
WebCore/html/DateComponents.h:167:  One space before end of line comments  [whitespace/comments] [5]
Skipping input 'WebCore/html/ISODateTime.h': Can't open for reading
Total errors found: 5


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kent Tamura 2010-01-28 01:03:12 PST
Created attachment 47597 [details]
Patch
Comment 4 Darin Adler 2010-01-28 08:22:17 PST
Comment on attachment 47597 [details]
Patch

Great. Thanks for doing this!
Comment 5 WebKit Commit Bot 2010-01-28 08:47:13 PST
Comment on attachment 47597 [details]
Patch

Clearing flags on attachment: 47597

Committed r54003: <http://trac.webkit.org/changeset/54003>
Comment 6 WebKit Commit Bot 2010-01-28 08:47:19 PST
All reviewed patches have been landed.  Closing bug.