The performance of plain text pastes is highly non-linear.
<rdar://problem/5195056>
Created attachment 47586 [details] Patch
Attachment 47586 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] WebKit/mac/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 47589 [details] Patch2 Stripping unwanted tabs from ChangeLog files.
Comment on attachment 47589 [details] Patch2 I'm concerned about the Mail-specific workaround. Is that something Mail needs to keep doing? Can we get them to change? If so, that special case should probably have a version check.The WebCore part of the speedup looks good to me (and is an awesome idea).
(In reply to comment #5) > (From update of attachment 47589 [details]) > I'm concerned about the Mail-specific workaround. Is that something Mail needs > to keep doing? Can we get them to change? If so, that special case should > probably have a version check.The WebCore part of the speedup looks good to me > (and is an awesome idea). I agree with you. I've been talking to mail about this and they seem ok with fixing it for the next version. I should probably change the code to do the workaround only up to the current version. Any thoughts?
(In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 47589 [details] [details]) > > I'm concerned about the Mail-specific workaround. Is that something Mail needs > > to keep doing? Can we get them to change? If so, that special case should > > probably have a version check.The WebCore part of the speedup looks good to me > > (and is an awesome idea). > > I agree with you. I've been talking to mail about this and they seem ok with > fixing it for the next version. > I should probably change the code to do the workaround only up to the current > version. > Any thoughts? I think that's a good idea. We usually use a linked on-or-after check for things like that.
Created attachment 47648 [details] Patch3 Limiting the OS versions for the workaround.
Comment on attachment 47648 [details] Patch3 r=me
Committed revision 54036.