Bug 34235 – User Stylesheets do not get parsed using the correct compatibility mode in a Document

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

User stylesheets are always parsing in quirks mode, which means mixed case identifiers fail to match if a Document is really in strict mode.

[Dave Hyatt]

Created attachment 47579 [details]
Patch

[Darin Adler]

Comment on attachment 47579 [details]
Patch

> +        documentStyle->setHtmlHacks(true); // enable html specific rendering tricks

If I was moving this code, I would have changed it into a sentence comment and capitalized HTML.

> -    visuallyOrdered = false;
> +    m_visuallyOrdered = false;

Since you have to touch this line anyway, I suggest using constructor syntax instead of an assignment statement for it.

> +    if (Settings* docSettings = settings())

In other places we do "this->settings()" so we can name the local variable settings too. But you just pointed out to me this is another case of moved code.

> +    bool visuallyOrdered() const { return m_visuallyOrdered; }

We try to name boolean member functions so they finish a sentence "document <xxx>" so we would normally call this isVisuallyOrdered or hasVisuallyOrderedEncoding or whatever. Same for RenderStyle, etc. Not saying you need to change this now.

The code looks good. You pointed out the regression test does not work. review+ assuming you make a new version of the test that does work.

[Alexey Proskuryakov]

This was committed in <http://trac.webkit.org/changeset/54005>. I don't see anything in above comments indicating that this bug needs to stay open.