Bug 34227 - MessageEvent.data should deserialize in the context of the MessageEvent's global object
Summary: MessageEvent.data should deserialize in the context of the MessageEvent's glo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-27 14:38 PST by Oliver Hunt
Modified: 2010-01-27 23:59 PST (History)
3 users (show)

See Also:


Attachments
Patch (12.48 KB, patch)
2010-01-27 16:23 PST, Oliver Hunt
no flags Details | Formatted Diff | Diff
Patch (19.49 KB, patch)
2010-01-27 20:18 PST, Oliver Hunt
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-01-27 14:38:34 PST
MessageEvent.data should deserialize in the context of the MessageEvent's global object
Comment 1 Oliver Hunt 2010-01-27 16:23:44 PST
Created attachment 47572 [details]
Patch
Comment 2 Oliver Hunt 2010-01-27 16:24:30 PST
Comment on attachment 47572 [details]
Patch

Don't want actual review yet (as i don't have testcases yet)
Comment 3 Oliver Hunt 2010-01-27 20:18:56 PST
Created attachment 47587 [details]
Patch
Comment 4 WebKit Review Bot 2010-01-27 20:30:01 PST
Attachment 47587 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/216413
Comment 5 Maciej Stachowiak 2010-01-27 20:39:43 PST
Comment on attachment 47587 [details]
Patch

r=me
Comment 6 Oliver Hunt 2010-01-27 20:47:15 PST
Committed r53969: <http://trac.webkit.org/changeset/53969>
Comment 7 Eric Seidel (no email) 2010-01-27 23:58:59 PST
This change was a flamethrower.  But I think most of the tree has been put out.  Gtk still looks broken though.
Comment 8 Eric Seidel (no email) 2010-01-27 23:59:46 PST
--- /var/lib/buildbot/build/gtk-linux-release/build/layout-test-results/fast/dom/Window/window-postmessage-clone-frames-expected.txt	2010-01-27 23:38:26.000000000 -0800
+++ /var/lib/buildbot/build/gtk-linux-release/build/layout-test-results/fast/dom/Window/window-postmessage-clone-frames-actual.txt	2010-01-27 23:38:26.000000000 -0800
@@ -5,8 +5,8 @@
 PASS: (frames[0].tests[1]).event.data instanceof (frames[0]).Array is true of type boolean
 PASS: (frames[0].tests[2]).eventData instanceof (frames[0]).Date is true of type boolean
 PASS: (frames[0].tests[2]).event.data instanceof (frames[0]).Date is true of type boolean
-PASS: (frames[0].tests[3]).eventData instanceof (frames[0]).File is true of type boolean
-PASS: (frames[0].tests[3]).event.data instanceof (frames[0]).File is true of type boolean
+FAIL: (frames[0].tests[3]).eventData instanceof (frames[0]).File is false should be true of type boolean
+FAIL: (frames[0].tests[3]).event.data instanceof (frames[0]).File is false should be true of type boolean
 PASS: (frames[0].tests[4]).eventData instanceof (frames[0]).FileList is true of type boolean
 PASS: (frames[0].tests[4]).event.data instanceof (frames[0]).FileList is true of type boolean