Bug 34226 - [v8]: Regression: onunload event handling
Summary: [v8]: Regression: onunload event handling
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: John Abd-El-Malek
Depends on:
Reported: 2010-01-27 13:39 PST by John Abd-El-Malek
Modified: 2010-01-27 17:41 PST (History)
2 users (show)

See Also:

Proposed patch (6.68 KB, patch)
2010-01-27 14:27 PST, John Abd-El-Malek
dglazkov: review-
Details | Formatted Diff | Diff
Renamed both tests to use dashes (11.21 KB, patch)
2010-01-27 15:56 PST, John Abd-El-Malek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2010-01-27 13:39:00 PST
(from http://code.google.com/p/chromium/issues/detail?id=33242)

If a page removes an iframe using removeChild and that frame sleeps in its unload handler, then when we terminate JS, we'll also terminate the outer page's JS.  Dimitri suggested throwing an exception instead.
Comment 1 John Abd-El-Malek 2010-01-27 14:27:46 PST
Created attachment 47563 [details]
Proposed patch
Comment 2 Dimitri Glazkov (Google) 2010-01-27 14:30:17 PST
Comment on attachment 47563 [details]
Proposed patch

I think this is a much gentler, kinder version of the change. I like it. Small nit: can you convert the file name of the test to dashes? We don't really use underscores.
Comment 3 John Abd-El-Malek 2010-01-27 15:56:52 PST
Created attachment 47569 [details]
Renamed both tests to use dashes
Comment 4 Dimitri Glazkov (Google) 2010-01-27 15:57:57 PST
Comment on attachment 47569 [details]
Renamed both tests to use dashes

Comment 5 WebKit Commit Bot 2010-01-27 17:41:38 PST
Comment on attachment 47569 [details]
Renamed both tests to use dashes

Clearing flags on attachment: 47569

Committed r53965: <http://trac.webkit.org/changeset/53965>
Comment 6 WebKit Commit Bot 2010-01-27 17:41:45 PST
All reviewed patches have been landed.  Closing bug.