WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 34225
Add FrameLoaderClient::allowImages method to allow the client to overrule image loading policy on a per frame basis
https://bugs.webkit.org/show_bug.cgi?id=34225
Summary
Add FrameLoaderClient::allowImages method to allow the client to overrule ima...
Darin Fisher (:fishd, Google)
Reported
2010-01-27 13:32:41 PST
Add FrameLoaderClient::allowImages method to allow the client to overrule image loading policy on a per frame basis This should work similarly to allowPlugins and allowJavaScript.
Attachments
v1 patch
(10.27 KB, patch)
2010-01-29 00:24 PST
,
Darin Fisher (:fishd, Google)
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1
2010-01-29 00:14:51 PST
For completeness, I'm also adding a Settings::areImagesEnabled. This is different from loadsImagesAutomatically as I explain in the patch comments.
Darin Fisher (:fishd, Google)
Comment 2
2010-01-29 00:24:22 PST
Created
attachment 47686
[details]
v1 patch
Adam Barth
Comment 3
2010-01-29 00:27:42 PST
Comment on
attachment 47686
[details]
v1 patch LGTM. As we discussed, either you or I owe Sam a test for this patch. We should be able to write the test at the same time as the test for allowPlugins.
Darin Fisher (:fishd, Google)
Comment 4
2010-01-29 00:44:23 PST
Landed as
http://trac.webkit.org/changeset/54049
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug