Bug 34225 - Add FrameLoaderClient::allowImages method to allow the client to overrule image loading policy on a per frame basis
Summary: Add FrameLoaderClient::allowImages method to allow the client to overrule ima...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-27 13:32 PST by Darin Fisher (:fishd, Google)
Modified: 2010-01-29 00:44 PST (History)
2 users (show)

See Also:


Attachments
v1 patch (10.27 KB, patch)
2010-01-29 00:24 PST, Darin Fisher (:fishd, Google)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2010-01-27 13:32:41 PST
Add FrameLoaderClient::allowImages method to allow the client to overrule image loading policy on a per frame basis

This should work similarly to allowPlugins and allowJavaScript.
Comment 1 Darin Fisher (:fishd, Google) 2010-01-29 00:14:51 PST
For completeness, I'm also adding a Settings::areImagesEnabled.  This is different from loadsImagesAutomatically as I explain in the patch comments.
Comment 2 Darin Fisher (:fishd, Google) 2010-01-29 00:24:22 PST
Created attachment 47686 [details]
v1 patch
Comment 3 Adam Barth 2010-01-29 00:27:42 PST
Comment on attachment 47686 [details]
v1 patch

LGTM.

As we discussed, either you or I owe Sam a test for this patch.  We should be able to write the test at the same time as the test for allowPlugins.
Comment 4 Darin Fisher (:fishd, Google) 2010-01-29 00:44:23 PST
Landed as http://trac.webkit.org/changeset/54049