Bug 34224 - [v8] minor cosmetic fix in V8 bindings codegenerator
Summary: [v8] minor cosmetic fix in V8 bindings codegenerator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-27 12:19 PST by anton muhin
Modified: 2010-01-28 08:37 PST (History)
2 users (show)

See Also:


Attachments
First take (1.33 KB, patch)
2010-01-27 12:22 PST, anton muhin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2010-01-27 12:19:06 PST
Need to swap , and a space.
Comment 1 anton muhin 2010-01-27 12:22:04 PST
Created attachment 47557 [details]
First take
Comment 2 anton muhin 2010-01-27 13:31:48 PST
Comment on attachment 47557 [details]
First take

Thanks, David.
Comment 3 WebKit Commit Bot 2010-01-27 14:41:58 PST
Comment on attachment 47557 [details]
First take

Clearing flags on attachment: 47557

Committed r53953: <http://trac.webkit.org/changeset/53953>
Comment 4 WebKit Commit Bot 2010-01-27 14:42:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Barth 2010-01-27 23:45:14 PST
Oh good.  I thought v9 was making a comeback.
Comment 6 anton muhin 2010-01-28 03:36:24 PST
(In reply to comment #5)
> Oh good.  I thought v9 was making a comeback.

Huh?  Oh should I take it off the bug?
Comment 7 Adam Barth 2010-01-28 08:30:42 PST
For a while, there were two versions of the V8 API, one called v8 and one called v9.  If you think life is confusing now, you should have seen that!  Thankfully, v9 killed v8, so the API we use now is technically v9, but we kept the v8 name because sounds better.  :)
Comment 8 anton muhin 2010-01-28 08:37:05 PST
(In reply to comment #7)
> For a while, there were two versions of the V8 API, one called v8 and one
> called v9.  If you think life is confusing now, you should have seen that! 
> Thankfully, v9 killed v8, so the API we use now is technically v9, but we kept
> the v8 name because sounds better.  :)

Cool.  Thanks a lot for explanations.