Bug 34223 - Remove trailing \ from inline function code
Summary: Remove trailing \ from inline function code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-27 12:04 PST by anton muhin
Modified: 2010-01-27 14:59 PST (History)
1 user (show)

See Also:


Attachments
First patch (1.63 KB, patch)
2010-01-27 12:07 PST, anton muhin
no flags Details | Formatted Diff | Diff
Adding spaces around - (1.64 KB, patch)
2010-01-27 12:30 PST, anton muhin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description anton muhin 2010-01-27 12:04:32 PST
That's most probably remnants of refactoring which turned a macro into a function.
Comment 1 anton muhin 2010-01-27 12:07:41 PST
Created attachment 47556 [details]
First patch
Comment 2 Darin Adler 2010-01-27 12:27:45 PST
Comment on attachment 47556 [details]
First patch

Comments should also be "//" instead of "/*".

Spaces should be around the "-" operator too, not just the "<<" operator.
Comment 3 anton muhin 2010-01-27 12:30:34 PST
Created attachment 47558 [details]
Adding spaces around -
Comment 4 anton muhin 2010-01-27 12:31:12 PST
(In reply to comment #2)
> (From update of attachment 47556 [details])
> Comments should also be "//" instead of "/*".
> 
> Spaces should be around the "-" operator too, not just the "<<" operator.

Thanks, done.
Comment 5 anton muhin 2010-01-27 13:32:41 PST
Comment on attachment 47558 [details]
Adding spaces around -

Thanks, Darin.
Comment 6 WebKit Commit Bot 2010-01-27 14:59:30 PST
Comment on attachment 47558 [details]
Adding spaces around -

Clearing flags on attachment: 47558

Committed r53954: <http://trac.webkit.org/changeset/53954>
Comment 7 WebKit Commit Bot 2010-01-27 14:59:35 PST
All reviewed patches have been landed.  Closing bug.