http/tests/navigation/anchor-basic.html timed out on Snow Leopard Release Bot
Been here for a long time:
See new diff:
This test fails every now and then on Snow Leopard bots. Note that this test is skipped on Leopard (see the bug 34222).
Do we know what other test result its showing there? It seems like some other test might be polluting this one?
(In reply to comment #2)
> Do we know what other test result its showing there? It seems like some other test might be polluting this one?
That test is even older.
We obviously could disable one or both of these tests, but best would be to understand the interaction going on and fix the underlying bug in WebCore or DumpRenderTree.
Created attachment 108918 [details]
Comment on attachment 108918 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=108918&action=review
> + Add waitUntilDone/notifyDone to eliminate flakiness on mac. Without
> + it, the img onload handler doesn't always run. Also reduce the
> + multipart timeout (should help to unblock other http requests).
Could you re-format the comment so that it doesn't use double-space? Also it seems awkward for "it" to appear at the beginning of a line or "the" to appear at the end of a line.
Created attachment 108935 [details]
Patch for landing
Comment on attachment 108935 [details]
Patch for landing
Clearing flags on attachment: 108935
Committed r96174: <http://trac.webkit.org/changeset/96174>
All reviewed patches have been landed. Closing bug.
It make http/tests/multipart/stop-crash.html fail on the GTK and the Qt bots:
@@ -1,6 +1,7 @@
+FAIL: Timed out waiting for notifyDone to be called
Test for http://bugs.webkit.org/show_bug.cgi?id=13360 REGRESSION: Crash closing live web cam viewer page.
If WebKit does not assert or crash after the test, then it passed.
It seems it is a bug somewhere in GTK and Qt port.
New bug report filed: https://bugs.webkit.org/show_bug.cgi?id=68979
http/tests/navigation/anchor-basic.html has passed every run after this patch landed. Looks like that was the problem.