Bug 34216 - AccessibilityController.h doesn't compile with RealView ARM compilers
Summary: AccessibilityController.h doesn't compile with RealView ARM compilers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-27 08:20 PST by George Wright
Modified: 2010-01-27 17:05 PST (History)
1 user (show)

See Also:


Attachments
Add missing #include (844 bytes, patch)
2010-01-27 08:37 PST, George Wright
manyoso: review-
Details | Formatted Diff | Diff
Add ChangeLog (1.33 KB, patch)
2010-01-27 08:50 PST, George Wright
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description George Wright 2010-01-27 08:20:38 PST
When trying to compile using RealView I get the following error:

"../../../WebKitTools/DumpRenderTree/AccessibilityController.h", line 30: Error:  #59: function call is not allowed in a constant expression
  #if PLATFORM(WIN)
      ^
"../../../WebKitTools/DumpRenderTree/AccessibilityController.h", line 56: Error:  #59: function call is not allowed in a constant expression
  #if PLATFORM(WIN)
      ^

This only seems to happen with RealView (I'm using RVCT 4).
Comment 1 George Wright 2010-01-27 08:37:55 PST
Created attachment 47540 [details]
Add missing #include

Add missing include for wtf/Platform.h so that the #if PLATFORM(WIN) statement doesn't result in an error.
Comment 2 Adam Treat 2010-01-27 08:41:32 PST
Comment on attachment 47540 [details]
Add missing #include

Add a real changelog please.
Comment 3 George Wright 2010-01-27 08:50:28 PST
Created attachment 47542 [details]
Add ChangeLog

Update to previous patch to include a proper ChangeLog.
Comment 4 WebKit Commit Bot 2010-01-27 17:05:49 PST
Comment on attachment 47542 [details]
Add ChangeLog

Clearing flags on attachment: 47542

Committed r53962: <http://trac.webkit.org/changeset/53962>
Comment 5 WebKit Commit Bot 2010-01-27 17:05:54 PST
All reviewed patches have been landed.  Closing bug.