RESOLVED FIXED 34213
Add layout tests to verify assignment to items of NodeList 
https://bugs.webkit.org/show_bug.cgi?id=34213
Summary Add layout tests to verify assignment to items of NodeList
anton muhin
Reported 2010-01-27 06:07:43 PST
Add layout tests to verify assignment to items of NodeList
Attachments
Patch (2.38 KB, patch)
2010-01-27 06:17 PST, anton muhin 		no flags
DetailsFormatted DiffDiff
First take (2.41 KB, patch)
2010-01-27 07:04 PST, anton muhin 		no flags
DetailsFormatted DiffDiff
Reference to Chromium bug added (2.58 KB, patch)
2010-01-28 05:26 PST, anton muhin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
anton muhin
Comment 1 2010-01-27 06:17:15 PST
Created attachment 47526 [details] Patch
anton muhin
Comment 2 2010-01-27 07:04:34 PST
Created attachment 47528 [details] First take
anton muhin
Comment 3 2010-01-27 07:05:17 PST
(In reply to comment #2) > Created an attachment (id=47528) [details] > First take It passes on both WebKit and Chromium's ToTs.
Alexey Proskuryakov
Comment 4 2010-01-27 13:49:35 PST
Is this a regression test for some previously fixed bug? Why 13 iterations?
anton muhin
Comment 5 2010-01-27 14:05:52 PST
(In reply to comment #4) > Is this a regression test for some previously fixed bug? Why 13 iterations? Yes, precisely: http://code.google.com/p/chromium/issues/detail?id=27967 Technically for current V8 2 is enough, but I thought that 13 is a reasonable compromise. If you prefer to see smaller constant, np, I'd only ask it to be >= 2, ideally >= 3
Alexey Proskuryakov
Comment 6 2010-01-27 14:15:16 PST
Comment on attachment 47528 [details] First take r=me I like to have a reference to the bug fixed in test output, but that's not really important, one can always do svn log.
anton muhin
Comment 7 2010-01-28 05:26:28 PST
Created attachment 47607 [details] Reference to Chromium bug added
anton muhin
Comment 8 2010-01-28 05:27:27 PST
(In reply to comment #6) > (From update of attachment 47528 [details]) > r=me > > I like to have a reference to the bug fixed in test output, but that's not > really important, one can always do svn log. I've added it into description. Is it fine?
Alexey Proskuryakov
Comment 9 2010-01-28 08:23:38 PST
Comment on attachment 47607 [details] Reference to Chromium bug added It is a little strange to see a link on a Web page that's plain text, and not clickable (one can use HTML tags in JS test description). But it's not a practical issue, no need to further change the patch.
anton muhin
Comment 10 2010-01-28 08:25:57 PST
Comment on attachment 47607 [details] Reference to Chromium bug added Thanks a lot for review, Alexey.
WebKit Commit Bot
Comment 11 2010-01-28 09:03:56 PST
Comment on attachment 47607 [details] Reference to Chromium bug added Clearing flags on attachment: 47607 Committed r54004: <http://trac.webkit.org/changeset/54004>
WebKit Commit Bot
Comment 12 2010-01-28 09:04:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.