The tests: http/tests/history/redirect-301.pl http/tests/history/redirect-302.pl http/tests/history/redirect-303.pl http/tests/history/redirect-307.pl are failing because keepWebHistoryMethos is not being called
(In reply to comment #0) > The tests: > > http/tests/history/redirect-301.pl > http/tests/history/redirect-302.pl > http/tests/history/redirect-303.pl > http/tests/history/redirect-307.pl > > are failing because keepWebHistoryMethos is not being called They're failing because QtWebKit does not parse/load the html body of the redirecting page so the layoutTestController commands don't get executed. The strange thing is a variety of other redirect requests depend on the fact that the body of a redirecting page is not displayed, so I'm not sure how other ports manage to execute the controller commands in the page without displaying it. They are certainly calling client->didReceiveData() which will load the page. Also, Qt's redirect logic is heavily embedded in QNetworkReplyHandler and it seems pretty fundamental there that a redirecting page won't get loaded. Not easy to work around this, even for tests, without breaking stuff.
Created attachment 64758 [details] Remove outdated references to renamed tests These tests have been renamed on http://trac.webkit.org/changeset/65340 (together with several changes in WebCore) And since them they're passing the Qt bot without problems. This patch just removes the outdated references from the Skipped file - I assume we can close this bug since the tests are passing for a while now.
Comment on attachment 64758 [details] Remove outdated references to renamed tests Rejecting patch 64758 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20870 test cases. media/video-preload.html -> crashed Exiting early after 1 failures. 17238 tests run. 780.96s total testing time 17237 test cases (99%) succeeded 1 test case (<1%) crashed 36 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3712377
Comment on attachment 64758 [details] Remove outdated references to renamed tests It was a flakey fail, cq+ -ed again.
Comment on attachment 64758 [details] Remove outdated references to renamed tests Clearing flags on attachment: 64758 Committed r65662: <http://trac.webkit.org/changeset/65662>
All reviewed patches have been landed. Closing bug.