Bug 34209 – rangeOverflow/rangeUnderflow support for type=date

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

rangeOverflow/rangeUnderflow flags of ValidityState support for <input type=date>.

[Kent Tamura]

Created attachment 47513 [details]
Proposed patch

[Darin Adler]

Comment on attachment 47513 [details]
Proposed patch

> +    // Parses the src for the current type, and return the double
> +    // value for the parsing result if the parsing succeeds; Returns
> +    // defaultValue otherwise. This function can return NaN or
> +    // Infinity only if defaultValue is NaN or Infinity.
> +    double doubleValueFor(const String& src, double defaultValue) const;

If you think that the argument name is really needed, then please use the word "source" instead of the abbreviation "src". I think you can omit the argument name.

Might be nicer if this function name made it clearer it was a string parser. I'm not sure "double value for <xxx>" implies parsing.

[Kent Tamura]

(In reply to comment #2)
> If you think that the argument name is really needed, then please use the word
> "source" instead of the abbreviation "src". I think you can omit the argument
> name.

I removed "src" and changed the wording.

> Might be nicer if this function name made it clearer it was a string parser.
> I'm not sure "double value for <xxx>" implies parsing.

Renamed to parseToDouble().

Landed as r53975.