RESOLVED FIXED 34201
Web Inspector: Switching between Profiles and Resources puts Profiles into "welcome screen" mode.
https://bugs.webkit.org/show_bug.cgi?id=34201
Summary Web Inspector: Switching between Profiles and Resources puts Profiles into "w...
Pavel Feldman
Reported 2010-01-26 23:53:33 PST
1. Start / stop profiling 2. Click on a resource link to get navigated to resources / scripts 3. Click on Profiler toolbar button to get back Expected: your profile selected Actual: profiler welcome screen
Attachments
proposed patch (6.57 KB, patch)
2010-01-27 04:57 PST, Mikhail Naganov
no flags
now using div (7.58 KB, patch)
2010-01-27 06:03 PST, Mikhail Naganov
no flags
assign more specialized class name to the div (7.64 KB, patch)
2010-01-27 07:15 PST, Mikhail Naganov
no flags
Mikhail Naganov
Comment 1 2010-01-27 04:57:27 PST
Created attachment 47519 [details] proposed patch
Pavel Feldman
Comment 2 2010-01-27 05:30:23 PST
Comment on attachment 47519 [details] proposed patch > + width: 0; Should we use div instead?
Mikhail Naganov
Comment 3 2010-01-27 06:03:39 PST
Created attachment 47523 [details] now using div
Mikhail Naganov
Comment 4 2010-01-27 07:15:00 PST
Created attachment 47529 [details] assign more specialized class name to the div
Timothy Hatcher
Comment 5 2010-01-27 08:25:48 PST
Comment on attachment 47529 [details] assign more specialized class name to the div Why remove the image?
Pavel Feldman
Comment 6 2010-01-27 08:32:53 PST
(In reply to comment #5) > (From update of attachment 47529 [details]) > Why remove the image? Image is still there on the enabler panel. It is just that going from enabler panel to the welcome screen with the same image moving to the left was confusing.
Timothy Hatcher
Comment 7 2010-01-27 08:36:27 PST
Ok.
Timothy Hatcher
Comment 8 2010-01-27 08:37:29 PST
Comment on attachment 47529 [details] assign more specialized class name to the div > +.panel-enabler-view.welcome div.welcome-instructions-aligner { > + display: inline-block; > + width: 0; > } A better way to hide the image is display: none.
Mikhail Naganov
Comment 9 2010-01-27 12:42:22 PST
(In reply to comment #8) > (From update of attachment 47529 [details]) > > > +.panel-enabler-view.welcome div.welcome-instructions-aligner { > > + display: inline-block; > > + width: 0; > > } > > A better way to hide the image is display: none. The image is already removed by not creating 'img' node (WelcomeView.js:22--24.) The purpose of this div is to align 'instructions' div. 'instructions' has 'auto' height (because they have text content), and I couldn't find another way to align instructions vertically properly. On enabler panel an image has fixed height, and alignment is done by using auto margins (and absolute positioning with top and bottom set to 0), then the text on the right is vertically centered relative to the image. On welcome view I'm proposing to use a zero-width div with fixed height for that purpose. Do you know any better way for solving this?
Timothy Hatcher
Comment 10 2010-01-27 13:19:40 PST
I see that might be the only option then.
WebKit Commit Bot
Comment 11 2010-01-28 03:01:52 PST
Comment on attachment 47529 [details] assign more specialized class name to the div Rejecting patch 47529 from commit-queue. mnaganov@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 12 2010-01-28 04:34:09 PST
Comment on attachment 47529 [details] assign more specialized class name to the div Clearing flags on attachment: 47529 Committed r53996: <http://trac.webkit.org/changeset/53996>
WebKit Commit Bot
Comment 13 2010-01-28 04:34:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.