Bug 34198 - Ruby text should not inherit line-height
Summary: Ruby text should not inherit line-height
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://www.google.com/support/forum/p...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-26 22:02 PST by Kent Tamura
Modified: 2010-02-02 22:36 PST (History)
1 user (show)

See Also:

Attachments
Demo HTML (153 bytes, text/html)
2010-01-26 22:02 PST, Kent Tamura 		no flags Details
patch - reset line-height in the UA stylesheet (4.09 KB, patch)
2010-01-27 04:45 PST, Roland Steiner 		eric: review-
Details | Formatted Diff | Diff
patch - reset line-height in the UA stylesheet, new layout test (4.61 KB, patch)
2010-02-01 21:01 PST, Roland Steiner 		adele: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-01-26 22:02:29 PST 
Created attachment 47493 [details]
Demo HTML

Reported in Google Chrome Help Forum (Japanese).

If ruby base text has line-height CSS property, the ruby text for it also has the line-height in the current implementation.

I'll attach a demo code.  'tttt' should not be placed apart from 'bbbb'.
Comment 1 Roland Steiner 2010-01-27 04:45:36 PST 
Created attachment 47518 [details]
patch - reset line-height in the UA stylesheet
Comment 2 Eric Seidel (no email) 2010-02-01 15:42:53 PST 
Comment on attachment 47518 [details]
patch - reset line-height in the UA stylesheet

Woh.  Batman, I think we need a helper function in that test case (instead of 3 sets of the same copy/paste code).    Why wouldnt' this be a script-test anyway?
Comment 3 Roland Steiner 2010-02-01 21:01:32 PST 
Created attachment 47904 [details]
patch - reset line-height in the UA stylesheet, new layout test

Zounds, holy statement of what should have been obvious! A script-test is of course more appropriate. Changed the layout test as suggested.
Comment 4 Roland Steiner 2010-02-02 22:36:50 PST 
Landed as rev. 54273