This bug addresses a //FIXME on line 48 in WebCore/rendering/RenderMedia.cpp. HTML5 media controls currently have hard-coded, platform-independent duration values for the fade in and fade out transitions. These should be configurable on a style or theme level. This allows the transition to be controlled on a platform level. This is of particular benefit to platforms wishing to avoid the composition of semitransparent controls on to video for performance reasons. Affected Lines: WebCore/rendering/RenderMedia.cpp: 48-50, 58, 70, 455-458 (Line numbers accurate at r53888)
Created attachment 47487 [details] Proposed change Fade in/out duration pulled from theme.
Comment on attachment 47487 [details] Proposed change r=me
Created attachment 47570 [details] Reviewed Patch. Added RevBy. Ready for Commit Queue.
Comment on attachment 47570 [details] Reviewed Patch. Rejecting patch 47570 from review queue. nicholas.young@nokia.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights.
Comment on attachment 47570 [details] Reviewed Patch. Rejecting patch 47570 from commit-queue. nicholas.young@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights.
Created attachment 47573 [details] Whoops. Apparently I wasn't supposed to do that. Original Patch. Original Patch.
> Whoops. Apparently I wasn't supposed to do that. Original Patch. > Just set the 'commit-queue?' flag when you attach a patch for review if you want it to be automatically submitted.
Comment on attachment 47573 [details] Whoops. Apparently I wasn't supposed to do that. Original Patch. Rejecting patch 47573 from commit-queue. Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1 Last 500 characters of output: mmitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/i386/SelectionController.o /Users/eseidel/Projects/CommitQueue/WebCore/editing/SelectionController.cpp normal i386 c++ com.apple.compilers.gcc.4_2 Distributed-CompileC /Users/eseidel/Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/i386/RenderThemeMac.o /Users/eseidel/Projects/CommitQueue/WebCore/rendering/RenderThemeMac.mm normal i386 objective-c++ com.apple.compilers.gcc.4_2 (27 failures) Full output: http://webkit-commit-queue.appspot.com/results/215420
Oops, m_opacityAnimationStartTime and m_opacityAnimationDuration are doubles so mediaControlsFadeInDuration and mediaControlsFadeOutDuration need to return the same.
Created attachment 47585 [details] Updated Patch Fixing build on mac. I somehow had it my mind that m_opacityAnimationDuration was a float and not a double.
Comment on attachment 47585 [details] Updated Patch Third time is a charm? r=me
Comment on attachment 47585 [details] Updated Patch Clearing flags on attachment: 47585 Committed r53966: <http://trac.webkit.org/changeset/53966>
All reviewed patches have been landed. Closing bug.