WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
34194
[BREWMP] Add conversions between IntPoint and AEEPoint
https://bugs.webkit.org/show_bug.cgi?id=34194
Summary
[BREWMP] Add conversions between IntPoint and AEEPoint
Kwang Yul Seo
Reported
2010-01-26 20:07:57 PST
AEEPoint is the data type used by BREWMP to represent a point.
Attachments
Add conversions between IntPoint and AEEPoint
(3.40 KB, patch)
2010-01-26 20:12 PST
,
Kwang Yul Seo
eric
: review+
Details
Formatted Diff
Diff
Add conversions between IntPoint and AEEPoint
(3.35 KB, patch)
2010-02-01 16:48 PST
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2010-01-26 20:12:12 PST
Created
attachment 47486
[details]
Add conversions between IntPoint and AEEPoint
Eric Seidel (no email)
Comment 2
2010-02-01 15:40:48 PST
Comment on
attachment 47486
[details]
Add conversions between IntPoint and AEEPoint 4 : m_x(static_cast<int>(point.x)) 35 , m_y(static_cast<int>(point.y)) Why do you need static_cast? Shouldn't an int16 expand to an int32 without cast? Otherewise looks fine.
Kwang Yul Seo
Comment 3
2010-02-01 16:48:28 PST
Created
attachment 47880
[details]
Add conversions between IntPoint and AEEPoint Eric, you are right. I removed static_cast from int16 to int32.
WebKit Commit Bot
Comment 4
2010-02-02 02:27:27 PST
Comment on
attachment 47880
[details]
Add conversions between IntPoint and AEEPoint Clearing flags on attachment: 47880 Committed
r54219
: <
http://trac.webkit.org/changeset/54219
>
WebKit Commit Bot
Comment 5
2010-02-02 02:27:34 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug