Bug 34194 – [BREWMP] Add conversions between IntPoint and AEEPoint

Bug 34194 - [BREWMP] Add conversions between IntPoint and AEEPoint


Summary:	[BREWMP] Add conversions between IntPoint and AEEPoint

Status:	RESOLVED FIXED

Product:	WebKit
Classification:	Unclassified
Component:	Platform
Version:	528+ (Nightly build)
Platform:	Other Other

Importance:	P2 Normal
Assigned To:	Nobody

URL:
Keywords:

Depends on:
Blocks:	33564
	Show dependency tree / graph

Reported:	2010-01-26 20:07 PST by Kwang Yul Seo
Modified:	2010-02-02 02:27 PST (History)
CC List:	2 users (show)

See Also:

Attachments
Add conversions between IntPoint and AEEPoint (3.40 KB, patch) 2010-01-26 20:12 PST, Kwang Yul Seo	eric: review+	Details \| Formatted Diff \| Diff
Add conversions between IntPoint and AEEPoint (3.35 KB, patch) 2010-02-01 16:48 PST, Kwang Yul Seo	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kwang Yul Seo 2010-01-26 20:07:57 PST

AEEPoint is the data type used by BREWMP to represent a point.

Comment 1 Kwang Yul Seo 2010-01-26 20:12:12 PST

Created attachment 47486 [details]
Add conversions between IntPoint and AEEPoint

Comment 2 Eric Seidel 2010-02-01 15:40:48 PST

Comment on attachment 47486 [details]
Add conversions between IntPoint and AEEPoint

4     : m_x(static_cast<int>(point.x))
 35     , m_y(static_cast<int>(point.y))

Why do you need static_cast?  Shouldn't an int16 expand to an int32 without cast?

Otherewise looks fine.

Comment 3 Kwang Yul Seo 2010-02-01 16:48:28 PST

Created attachment 47880 [details]
Add conversions between IntPoint and AEEPoint

Eric, you are right. I removed static_cast from int16 to int32.

Comment 4 WebKit Commit Bot 2010-02-02 02:27:27 PST

Comment on attachment 47880 [details]
Add conversions between IntPoint and AEEPoint

Clearing flags on attachment: 47880

Committed r54219: <http://trac.webkit.org/changeset/54219>

Comment 5 WebKit Commit Bot 2010-02-02 02:27:34 PST

All reviewed patches have been landed.  Closing bug.