WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
34190
[BREWMP] Remove COMPILE_ASSERT conflict with the underlying PLATFORM
https://bugs.webkit.org/show_bug.cgi?id=34190
Summary
[BREWMP] Remove COMPILE_ASSERT conflict with the underlying PLATFORM
Kwang Yul Seo
Reported
2010-01-26 16:48:43 PST
COMPILE_ASSERT conflicts with the underlying PLATFORM because it is defined both in WTF's Assertions.h and BREWMP's AEEClassIDs.h. Include "AEEClassIDs.h" in Assertions.h and undef COMPILE_ASSERT to avoid redefining COMPILE_ASSERT.
Attachments
Remove COMPILE_ASSERT conflict
(1.42 KB, patch)
2010-01-26 16:52 PST
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2010-01-26 16:52:32 PST
Created
attachment 47462
[details]
Remove COMPILE_ASSERT conflict
Eric Seidel (no email)
Comment 2
2010-02-03 13:06:11 PST
Comment on
attachment 47462
[details]
Remove COMPILE_ASSERT conflict It seems strange to me to include AEEClassIDs.h I assume that's where COMPILE_ASSERT is defined?
WebKit Commit Bot
Comment 3
2010-02-03 13:43:43 PST
Comment on
attachment 47462
[details]
Remove COMPILE_ASSERT conflict Clearing flags on attachment: 47462 Committed
r54296
: <
http://trac.webkit.org/changeset/54296
>
WebKit Commit Bot
Comment 4
2010-02-03 13:43:51 PST
All reviewed patches have been landed. Closing bug.
Kwang Yul Seo
Comment 5
2010-02-03 18:59:00 PST
(In reply to
comment #2
)
> (From update of
attachment 47462
[details]
) > It seems strange to me to include AEEClassIDs.h > > I assume that's where COMPILE_ASSERT is defined?
Yes. COMPILE_ASSERT is defined in AEEClassIDs.h.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug