WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
34187
webkit-patch commit-queue should land patches optimistically
https://bugs.webkit.org/show_bug.cgi?id=34187
Summary
webkit-patch commit-queue should land patches optimistically
Eric Seidel (no email)
Reported
2010-01-26 15:44:46 PST
webkit-patch commit-queue should land patches optimistically Right now it builds and tests tip-of-tree first, and if the tests pass, applies the patch and builds and tests with the patch. We should instead apply the patch, build and test, and if they pass land. If tests didn't pass, try trunk. If trunk passed, reject the patch. Otherwise, spin. Adam gets all the credit for this masterful idea. Should make the commit-queue *much* faster.
Attachments
Patch
(4.83 KB, patch)
2010-03-31 12:27 PDT
,
Adam Barth
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-03-31 12:27:09 PDT
Created
attachment 52194
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-03-31 12:29:49 PDT
Comment on
attachment 52194
[details]
Patch Slightly confusing, but maximally awesome.
Adam Barth
Comment 3
2010-03-31 12:32:42 PDT
Committed
r56857
: <
http://trac.webkit.org/changeset/56857
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug