Bug 34187 - webkit-patch commit-queue should land patches optimistically
Summary: webkit-patch commit-queue should land patches optimistically
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-26 15:44 PST by Eric Seidel (no email)
Modified: 2010-03-31 12:32 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.83 KB, patch)
2010-03-31 12:27 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-01-26 15:44:46 PST 
webkit-patch commit-queue should land patches optimistically

Right now it builds and tests tip-of-tree first, and if the tests pass, applies the patch and builds and tests with the patch.

We should instead apply the patch, build and test, and if they pass land.
If tests didn't pass, try trunk.  If trunk passed, reject the patch.  Otherwise, spin.

Adam gets all the credit for this masterful idea.

Should make the commit-queue *much* faster.
Comment 1 Adam Barth 2010-03-31 12:27:09 PDT 
Created attachment 52194 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-03-31 12:29:49 PDT 
Comment on attachment 52194 [details]
Patch

Slightly confusing, but maximally awesome.
Comment 3 Adam Barth 2010-03-31 12:32:42 PDT 
Committed r56857: <http://trac.webkit.org/changeset/56857>