Bug 34186 - [chromium] complex text draws newlines as bells
Summary: [chromium] complex text draws newlines as bells
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-26 15:38 PST by Evan Martin
Modified: 2010-01-27 16:17 PST (History)
2 users (show)

See Also:


Attachments
patch (5.42 KB, patch)
2010-01-26 15:52 PST, Evan Martin
no flags Details | Formatted Diff | Diff
patch (5.39 KB, patch)
2010-01-26 16:05 PST, Evan Martin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2010-01-26 15:38:50 PST
http://code.google.com/p/chromium/issues/detail?id=33122 has a screenshot.

It's because we don't filter out newlines before handing the text to Harfbuzz, and it thinks the bell is a good glyph for showing a newline.
Comment 1 Evan Martin 2010-01-26 15:52:31 PST
Created attachment 47454 [details]
patch
Comment 2 Evan Martin 2010-01-26 16:05:00 PST
Created attachment 47455 [details]
patch
Comment 3 Evan Martin 2010-01-27 15:01:02 PST
Comment on attachment 47455 [details]
patch

was waiting for agl to glance at this -- he says it looks fine, so it's ready for commit
Comment 4 WebKit Commit Bot 2010-01-27 16:17:01 PST
Comment on attachment 47455 [details]
patch

Clearing flags on attachment: 47455

Committed r53958: <http://trac.webkit.org/changeset/53958>
Comment 5 WebKit Commit Bot 2010-01-27 16:17:06 PST
All reviewed patches have been landed.  Closing bug.