Bug 34171 - Web Inspector: migrate from SourceFrame to SourceFrame2.
Summary: Web Inspector: migrate from SourceFrame to SourceFrame2.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2010-01-26 10:02 PST by Pavel Feldman
Modified: 2010-01-27 10:37 PST (History)
4 users (show)

See Also:

[PATCH] Proposed change. (92.41 KB, patch)
2010-01-26 10:03 PST, Pavel Feldman
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-01-26 10:02:08 PST
Patch that I will attach shortly has a number of limitations:
- poor performance on long lines
- search marks results with selection highlight
- HTML highlighter does not treat script tag well ( < inside script starts a tag)

But I will polish it all :)
Comment 1 Pavel Feldman 2010-01-26 10:03:31 PST
Created attachment 47419 [details]
[PATCH] Proposed change.
Comment 2 Pavel Feldman 2010-01-27 10:37:23 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	WebCore/inspector/front-end/SourceFrame2.js
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp
	M	WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp
	M	WebCore/inspector/InspectorFrontendHost.cpp
	M	WebCore/inspector/InspectorFrontendHost.h
	M	WebCore/inspector/InspectorFrontendHost.idl
	M	WebCore/inspector/front-end/InspectorBackendStub.js
	M	WebCore/inspector/front-end/InspectorFrontendHostStub.js
	M	WebCore/inspector/front-end/ResourceView.js
	M	WebCore/inspector/front-end/ResourcesPanel.js
	M	WebCore/inspector/front-end/ScriptView.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
	M	WebCore/inspector/front-end/SourceFrame.js
	M	WebCore/inspector/front-end/SourceView.js
	M	WebCore/inspector/front-end/TextEditor.js
	M	WebCore/inspector/front-end/WebKit.qrc
	M	WebCore/inspector/front-end/inspector.html
	M	WebCore/inspector/front-end/textEditor.css
Committed r53941