Bug 34165 - Web Inspector: add support for breakpoints, messages and search into the SourceFrame2.
Summary: Web Inspector: add support for breakpoints, messages and search into the Sour...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-26 05:24 PST by Pavel Feldman
Modified: 2010-01-26 08:42 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed change. (34.95 KB, patch)
2010-01-26 05:27 PST, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-01-26 05:24:34 PST 
Patch to follow shortly.
Comment 1 Pavel Feldman 2010-01-26 05:27:26 PST 
Created attachment 47406 [details]
[PATCH] Proposed change.
Comment 2 Timothy Hatcher 2010-01-26 08:25:04 PST 
Comment on attachment 47406 [details]
[PATCH] Proposed change.

> +            var column = line.indexOf(query);

This will be more restrictive than our current search. We are currently do a case insensitive search.
Comment 3 Pavel Feldman 2010-01-26 08:41:06 PST 
(In reply to comment #2)
> (From update of attachment 47406 [details])
> > +            var column = line.indexOf(query);
> 
> This will be more restrictive than our current search. We are currently do a
> case insensitive search.

I'll add toLowerCase or do a regex in the subsequent patch.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/SourceFrame2.js
	M	WebCore/inspector/front-end/TextEditor.js
	M	WebCore/inspector/front-end/TextEditorHighlighter.js
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/textEditor.css
Committed r53856