When debugger is paused on a breakpoint Local scope is displayed as With scope and 'this' variable is missing in it. This is a regression after http://trac.webkit.org/changeset/53766
Any word on this?
This only happens if the global object has a property with the same name of a variable in the scope chain :-/
Created attachment 47538 [details] patch
Created attachment 47539 [details] patch Added ChangeLog entry.
Comment on attachment 47539 [details] patch r=me
Comment on attachment 47539 [details] patch Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/js/JSInjectedScriptHostCustom.cpp M WebCore/inspector/InjectedScriptHost.idl M WebCore/inspector/front-end/InjectedScript.js A WebCore/manual-tests/inspector/debugger-scopes-inspection.html Committed r53945
Comment on attachment 47539 [details] patch > +JSValue JSInjectedScriptHost::isActivation(ExecState* exec, const ArgList& args) > +{ > + if (args.size() < 1) > + return jsUndefined(); > + > + JSValue value = args.at(0); > + if (!value.isObject()) > + return jsBoolean(false); > + > + JSObject* object = value.toObject(exec); > + return jsBoolean(object->isActivationObject()); This is unnecessarily inefficient. There is no need to check args.size() at all, since args.at(0) already does. And the toObject function is not needed for a value already known to be an object. The function could be this: JSObject* object = args.at(0).getObject(); return jsBoolean(object && object->isActivationObject());
Created attachment 47598 [details] patch isActivation code is simplified according to Darin's suggestion.
I'd like to improve the code.
Comment on attachment 47598 [details] patch Clearing flags on attachment: 47598 Committed r53993: <http://trac.webkit.org/changeset/53993>
All reviewed patches have been landed. Closing bug.