Bug 34149 - Some methods in JSC JNI bridge need more error checking of results from JNI.
Summary: Some methods in JSC JNI bridge need more error checking of results from JNI.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Java (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-25 16:28 PST by Gavin Barraclough
Modified: 2010-01-26 14:01 PST (History)
0 users

See Also:


Attachments
Preliminary patch (not even built!) (13.69 KB, patch)
2010-01-25 16:44 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
a patch (15.50 KB, patch)
2010-01-25 19:14 PST, Gavin Barraclough
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2010-01-25 16:28:23 PST
In JNIUtility.h, callJNIMethodV<jobject> might return null (from CallObjectMethodV, via JNICaller<jobject>::callV) if an exception is thrown.

All clients of callJNIMethodV<jobject> that are calling methods on the returned object should null check first.
Comment 1 Gavin Barraclough 2010-01-25 16:44:05 PST
Created attachment 47376 [details]
Preliminary patch (not even built!)
Comment 2 Gavin Barraclough 2010-01-25 19:14:56 PST
Created attachment 47381 [details]
a patch
Comment 3 Anders Carlsson 2010-01-26 13:46:07 PST
Comment on attachment 47381 [details]
a patch

Looks great! r=me with the changes we discussed (Change "[UNKNOWN ...]" to simply "Unknown")
Comment 4 Gavin Barraclough 2010-01-26 14:01:12 PST
Transmitting file data .......
Committed revision 53865.